Skip to content

Anna townsend#1

Open
AnnaTownsend9916 wants to merge 3 commits into
masterfrom
Anna-Townsend
Open

Anna townsend#1
AnnaTownsend9916 wants to merge 3 commits into
masterfrom
Anna-Townsend

Conversation

@AnnaTownsend9916
Copy link
Copy Markdown
Owner

Heyoo

Copy link
Copy Markdown
Collaborator

@jheinz1999 jheinz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on the right track, but still have a little bit of work to do. Keep working hard, you're almost there!

Comment thread about.html Outdated
Leverage agile frameworks to provide a robust synopsis for high level overviews. Iterative approaches to corporate strategy foster collaborative thinking to further the overall value proposition. Organically grow the holistic world view of disruptive innovation via workplace diversity and empowerment.

<header>
<div class=topOfAbout>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div may not be necessary, as it is the only child of the header tag

Comment thread about.html Outdated
<nav class=topNavAbout>
<a href="">Home</a>
<a href="about.html">About</a>
</html>Products</a>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a typo, but you don't want to end your tag here!

Comment thread about.html Outdated
</div>
</header>

<div class="container about-page">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This container could even go up above the header so it contains all of your content

Comment thread about.html Outdated

<div class="container about-page">
<section class='topAboutPage'>
<div>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this div may not be necessary

Comment thread about.html Outdated
<p class='aboutP'>Leverage agile frameworks to provide a robust synopsis for high level overviews. Iterative approaches to corporate strategy foster collaborative thinking to further the overall value proposition. Organically grow the holistic world view of disruptive innovation via workplace diversity and empowerment.</p>
</div>
</section>
<div class='strategyImg'>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for this div - because the image is the only child, there is no need to wrap it in a div

Comment thread about.html Outdated
<p class="strategyP"> Iterative approaches to corporate strategy foster collaborative thinking to further the overall value proposition.</p>

<button>Learn More</button>
</section>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are ending your section tag before the div tag, but the div tag is a child of the section tag

Comment thread about.html Outdated
<div>
<img src="img/about-working.png" alt="strategy">
</div>
<div class='howWeWorkContent'>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may not be necessary to have a section tag inside of a div tag, as the section is the only child

Comment thread css/index.css
}

.topOfHomePage{
display: flex;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job using flex!

Comment thread index.html
<div class="box">Box 8</div>
<div class="box">Box 9</div>
<div class="box">Box 10</div>
<div class="box" style='background-color: teal;'>Box 1</div>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For these boxes, we are actually looking for the use of selectors in your index.css file as opposed to the style property in HTML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants