Skip to content

Commit

Permalink
fixing eracle#6: listing only main requirements, renaming the docker …
Browse files Browse the repository at this point in the history
…folder, updating the dockerfile and using a docker volume instead of copying the project codebase
  • Loading branch information
eracle committed Sep 5, 2018
1 parent 944a07a commit df4b483
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 39 deletions.
7 changes: 7 additions & 0 deletions compose/local/Dockerfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
FROM python:3.6

# Requirements are installed here to ensure they will be cached.
COPY ./requirements /requirements
RUN pip install -r /requirements/production.txt

WORKDIR /app
5 changes: 3 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,12 @@ services:
- PYTHONUNBUFFERED=0
build:
context: .
dockerfile: ./docker_conf/prod/Dockerfile
dockerfile: compose/local/Dockerfile
depends_on:
- selenium
volumes:
- ./logs:/code/logs
- .:/app
- ./logs:/app/logs
selenium:
container_name: selenium
image: selenium/standalone-chrome-debug
Expand Down
7 changes: 0 additions & 7 deletions docker_conf/prod/Dockerfile

This file was deleted.

31 changes: 1 addition & 30 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,30 +1 @@
asn1crypto==0.24.0
attrs==18.2.0
Automat==0.7.0
cffi==1.11.5
constantly==15.1.0
cryptography==2.3.1
cssselect==1.0.3
hyperlink==18.0.0
idna==2.7
incremental==17.5.0
lxml==4.2.4
parsel==1.5.0
pluggy==0.7.1
py==1.6.0
pyasn1==0.4.4
pyasn1-modules==0.2.2
pycparser==2.18
PyDispatcher==2.0.5
pyOpenSSL==18.0.0
pytest==3.7.4
pytest-sugar==0.9.1
queuelib==1.5.0
Scrapy==1.5.1
selenium==3.14.0
service-identity==17.0.0
six==1.11.0
termcolor==1.1.0
Twisted==18.7.0
w3lib==1.19.0
zope.interface==4.5.0
-r requirements/production.txt
10 changes: 10 additions & 0 deletions requirements/production.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Scrapy
Scrapy>=1.5.1 # pyup: < 2.0 # https://github.com/scrapy/scrapy

# Selenium
selenium>=3.14.0 # pyup: < 4.0 # https://github.com/SeleniumHQ/selenium

# Testing
# todo: move them to a dedicated req file
pytest==3.7.4
pytest-sugar==0.9.1

0 comments on commit df4b483

Please sign in to comment.