Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visual Novel Example to Example branch #72

Draft
wants to merge 15 commits into
base: examples
Choose a base branch
from

Conversation

Crystalwarrior
Copy link
Collaborator

@Crystalwarrior Crystalwarrior commented Dec 31, 2021

Add a visual novel example, including a test timeline showing off blips, background transitions, etc

godette.adventures.mp4

.

Copy link
Owner

@AnidemDex AnidemDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it needs more comments to know what you were doing (I can understand what is happening here, but since we're on the examples branch, we need to do it with ELI5 as possible)

examples/VisualNovel/DialogPiece.tscn Outdated Show resolved Hide resolved
examples/VisualNovel/Main.gd Outdated Show resolved Hide resolved
@Crystalwarrior
Copy link
Collaborator Author

I think it needs more comments to know what you were doing (I can understand what is happening here, but since we're on the examples branch, we need to do it with ELI5 as possible)

I agree. I will excessively comment it once I have the code as modular and nice to read as possible

@AnidemDex
Copy link
Owner

Gonna merge this branch after you change the "text text text" placeholder with a proper one (like "placeholder text" or just ""). The other two revisions can be made in a different branch

Add layered sprites support
Add music support
Expand on the Godette Adventures
Copy link
Owner

@AnidemDex AnidemDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few points:

  • Restore .gdignore file
  • Are psd, xcf, lnk files necessary?

examples/VisualNovel/portrait_manager_ex.gd Show resolved Hide resolved
@Crystalwarrior
Copy link
Collaborator Author

A few points:

* Restore `.gdignore` file

* Are `psd`, `xcf`, `lnk` files necessary?

.psd, .xcf, etc. files are not really necessary, they could be distributed separately. Source files can be helpful for creators to understand how the sprites are composed tho.

Optimize Godette assets to be less huge filesize-wise
Remove base huge sprites and replace them with downscaled preview sprites for the editor instead
Remove Godette source files (huge file size, limited usefulness)
Enable BBCode on IC logs
Remove duplicate_logging option from ICLogs due to potentially being super laggy
@AnidemDex
Copy link
Owner

don't forget to rebase main and force push your branch when you're done to solve merge conflicts

Copy link
Owner

@AnidemDex AnidemDex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@Crystalwarrior
Copy link
Collaborator Author

Worked on my game, gotta backport a lot of new discoveries I made during its development into this example later

@AnidemDex AnidemDex marked this pull request as draft January 24, 2022 15:27
@AnidemDex
Copy link
Owner

Please, mark it as done when you think is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants