-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Github issue #1805 - Fix Real-Time Subtask Display via Worktree-Aware FileWatcher #1839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VDT-91
wants to merge
6
commits into
AndyMik90:develop
Choose a base branch
from
VDT-91:auto-claude/202-root-cause-high-confidence-subtask-updates-are-sil
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−10
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f98190c
auto-claude: subtask-1-1 - Update TASK_START handler to use worktree-…
VDT-91 048d177
auto-claude: subtask-1-2 - Update TASK_UPDATE_STATUS auto-start handl…
VDT-91 ba9180c
auto-claude: subtask-1-3 - TASK_RECOVER_STUCK handler already updated
VDT-91 48a1903
auto-claude: subtask-2-2 - Verify TypeScript compilation and existing…
VDT-91 5ede277
Merge branch 'develop' into auto-claude/202-root-cause-high-confidenc…
VDT-91 4700009
Merge branch 'develop' into auto-claude/202-root-cause-high-confidenc…
VDT-91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This logic to determine the
specDirby checking for a worktree is duplicated in three places in this file (here, lines 712-716, and lines 1153-1157). To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, this should be extracted into a single helper function.For example, you could create a function like
getSpecDirForWatcher:And then call it in all three places:
const specDir = getSpecDirForWatcher(project, task);This makes the code cleaner and avoids potential bugs if this logic needs to be updated in the future.