-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Fix subtask title display in task modal #1837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
e96c15e
e361795
69e32e8
0edba9a
4b21e63
41760db
0d3b2e7
c504c27
94fd2b6
dce8437
a5faf0e
a72de1c
0eaef26
20b5176
5373658
37530a4
87509b1
738aa29
dd72e95
e0f589e
1227f7a
37cb3db
969917b
149a675
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -232,6 +232,7 @@ Based on the workflow type and services involved, create the implementation plan | |
| "subtasks": [ | ||
| { | ||
| "id": "subtask-1-1", | ||
| "title": "Create data models for analytics", | ||
| "description": "Create data models for [feature]", | ||
| "service": "backend", | ||
| "files_to_modify": ["src/models/user.py"], | ||
|
Comment on lines
232
to
238
This comment was marked as outdated.
Sorry, something went wrong. |
||
|
|
@@ -246,6 +247,7 @@ Based on the workflow type and services involved, create the implementation plan | |
| }, | ||
| { | ||
| "id": "subtask-1-2", | ||
| "title": "Create API endpoints for analytics events", | ||
| "description": "Create API endpoints for [feature]", | ||
| "service": "backend", | ||
| "files_to_modify": ["src/routes/api.py"], | ||
|
|
@@ -272,6 +274,7 @@ Based on the workflow type and services involved, create the implementation plan | |
| "subtasks": [ | ||
| { | ||
| "id": "subtask-2-1", | ||
| "title": "Create aggregation Celery task", | ||
| "description": "Create aggregation Celery task", | ||
|
Comment on lines
+277
to
278
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The For example:
Comment on lines
276
to
278
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧹 Nitpick | 🔵 Trivial Example subtask has identical title and description — demonstrates the wrong pattern. Several examples (e.g., 🤖 Prompt for AI Agents |
||
| "service": "worker", | ||
| "files_to_modify": ["worker/tasks.py"], | ||
|
|
@@ -296,6 +299,7 @@ Based on the workflow type and services involved, create the implementation plan | |
| "subtasks": [ | ||
| { | ||
| "id": "subtask-3-1", | ||
| "title": "Create real-time dashboard component", | ||
| "description": "Create dashboard component", | ||
| "service": "frontend", | ||
| "files_to_modify": [], | ||
|
|
@@ -320,6 +324,7 @@ Based on the workflow type and services involved, create the implementation plan | |
| "subtasks": [ | ||
| { | ||
| "id": "subtask-4-1", | ||
| "title": "Verify end-to-end analytics flow", | ||
| "description": "End-to-end verification of analytics flow", | ||
| "all_services": true, | ||
| "files_to_modify": [], | ||
|
|
@@ -362,6 +367,7 @@ Use ONLY these values for the `type` field in phases: | |
| 2. **Small scope** - Each subtask should take 1-3 files max | ||
| 3. **Clear verification** - Every subtask must have a way to verify it works | ||
| 4. **Explicit dependencies** - Phases block until dependencies complete | ||
| 5. **Title must be a short imperative label** (max 60 chars, e.g. "Create data models for analytics"). Description contains full implementation details. | ||
|
|
||
| ### Verification Types | ||
|
|
||
|
|
@@ -385,6 +391,7 @@ Use ONLY these values for the `type` field in phases: | |
| ```json | ||
| { | ||
| "id": "subtask-investigate-1", | ||
| "title": "Identify root cause of memory leak", | ||
| "description": "Identify root cause of memory leak", | ||
|
Comment on lines
+394
to
395
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The For example: |
||
| "expected_output": "Document with: (1) Root cause, (2) Evidence, (3) Proposed fix", | ||
| "files_to_modify": [], | ||
|
|
@@ -400,6 +407,7 @@ Use ONLY these values for the `type` field in phases: | |
| ```json | ||
| { | ||
| "id": "subtask-refactor-1", | ||
| "title": "Add new auth system alongside old", | ||
| "description": "Add new auth system alongside old", | ||
|
Comment on lines
+410
to
411
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The For instance: |
||
| "files_to_modify": ["src/auth/index.ts"], | ||
| "files_to_create": ["src/auth/new_auth.ts"], | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Falsy check drops empty-string titles — use
is not Nonefor consistency.if self.title:skips serialization whentitleis"". Other optional fields in this method (e.g.,session_idon Line 79) correctly useis not None. Use the same pattern here to stay consistent and avoid silently losing data.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents