Skip to content

Commit

Permalink
Clarify use of relative paths in benching
Browse files Browse the repository at this point in the history
Mixing abs/rel paths is error prune due to multiple shell configs.
Maintain current expected relative paths only. But add the note to comments and help text on bench scripts
  • Loading branch information
AndyGrant committed Nov 12, 2024
1 parent 8b037cd commit 01c2dda
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions Client/bench.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@

# The sole purpose of this module is to invoke run_benchmark().
#
# - binary : Path to, and including, the Binary File
# - network : Path to Network File, or None
# - binary : Relative path to, and including, the Binary File
# - network : Relative path to a private engine's Network File, or None
# - private : True or False; Private NNUE engines require special care
# - threads : Number of concurrent benches to run
# - sets : Number of times to repeat this experiment
Expand Down
8 changes: 4 additions & 4 deletions Scripts/bench_engine.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@
if __name__ == '__main__':

p = argparse.ArgumentParser()
p.add_argument('-E', '--engine' , help='Binary Name', required=True)
p.add_argument('-N', '--network' , help='Networks for Private Engines', required=False)
p.add_argument('-T', '--threads' , help='Concurrent Benchmarks', required=True, type=int)
p.add_argument('-S', '--sets' , help='Benchmark Sample Count', required=True, type=int)
p.add_argument('-E', '--engine' , help='Relative path to Binary', required=True)
p.add_argument('-N', '--network' , help='Relative path to Network for Private Engines', required=False)
p.add_argument('-T', '--threads' , help='Concurrent Benchmarks', required=True, type=int)
p.add_argument('-S', '--sets' , help='Benchmark Sample Count', required=True, type=int)
args = p.parse_args()

private = args.network != None
Expand Down

0 comments on commit 01c2dda

Please sign in to comment.