Skip to content

Implement rotate() and mirror() for vertical slabs #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MUKSC wants to merge 2 commits into
base: 1.20.x
Choose a base branch
from
Open

Implement rotate() and mirror() for vertical slabs #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a4af90
Implement `rotate()` and `mirror()` for vertical slabs
MUKSC Feb 5, 2024
c757200
Fix wrong `mirror()` implementation
MUKSC Feb 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions src/main/java/io/github/andrew6rant/autoslabs/mixin/SlabBlockMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
import net.minecraft.entity.player.PlayerEntity;
import net.minecraft.item.ItemPlacementContext;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockMirror;
import net.minecraft.util.BlockRotation;
import net.minecraft.util.hit.BlockHitResult;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Direction;
Expand All @@ -25,6 +27,8 @@

import static io.github.andrew6rant.autoslabs.Util.TYPE;
import static io.github.andrew6rant.autoslabs.Util.VERTICAL_TYPE;
import static io.github.andrew6rant.autoslabs.VerticalType.*;
import static net.minecraft.block.enums.SlabType.BOTTOM;
import static net.minecraft.block.enums.SlabType.TOP;

@Mixin(SlabBlock.class)
Expand Down Expand Up @@ -83,4 +87,50 @@ public void afterBreak(World world, PlayerEntity player, BlockPos pos, BlockStat
}
}

@Override
public BlockState rotate(BlockState state, BlockRotation rotation) {
SlabType slabType = state.get(TYPE);
if (slabType == null) return super.rotate(state, rotation);
if (slabType == SlabType.DOUBLE) return state;

VerticalType verticalType = state.get(VERTICAL_TYPE);
if (verticalType == null) return super.rotate(state, rotation);
if (verticalType == FALSE || rotation == BlockRotation.NONE) return state;

return switch (rotation) {
case CLOCKWISE_90 -> state
.with(VERTICAL_TYPE, verticalType == NORTH_SOUTH ? EAST_WEST : NORTH_SOUTH)
.with(TYPE, verticalType == EAST_WEST ? (slabType == TOP ? BOTTOM : TOP) : slabType);
case CLOCKWISE_180 -> state
.with(TYPE, slabType == TOP ? BOTTOM : TOP);
case COUNTERCLOCKWISE_90 -> state
.with(VERTICAL_TYPE, verticalType == NORTH_SOUTH ? EAST_WEST : NORTH_SOUTH)
.with(TYPE, verticalType == NORTH_SOUTH ? (slabType == TOP ? BOTTOM : TOP) : slabType);
default -> state;
};
}

@Override
public BlockState mirror(BlockState state, BlockMirror mirror) {
SlabType slabType = state.get(TYPE);
if (slabType == null) return super.mirror(state, mirror);
if (slabType == SlabType.DOUBLE) return state;

VerticalType verticalType = state.get(VERTICAL_TYPE);
if (verticalType == null) return super.mirror(state, mirror);
if (verticalType == FALSE || mirror == BlockMirror.NONE) return state;

return switch (mirror) {
case LEFT_RIGHT -> switch (verticalType) {
case EAST_WEST -> state;
default -> state.with(TYPE, state.get(TYPE) == TOP ? BOTTOM : TOP);
};
case FRONT_BACK -> switch (verticalType) {
case NORTH_SOUTH -> state;
default -> state.with(TYPE, state.get(TYPE) == TOP ? BOTTOM : TOP);
};
default -> state;
};
}

}