Skip to content

Comments

Assignment 3#2

Open
AnaKanzaTariq wants to merge 5 commits intomainfrom
assignment-3
Open

Assignment 3#2
AnaKanzaTariq wants to merge 5 commits intomainfrom
assignment-3

Conversation

@AnaKanzaTariq
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

create visualizations

What did you learn from the changes you have made?

creating good images

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

no

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

no

How were these changes tested?

n/a

A reference to a related issue in your repository (if applicable)

Checklist

  • [ y] I can confirm that my changes are working as intended

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please make the following review changes for re-review -

  1. Upload the functioning .ipynb file instead of .md file for the Python Code.
  2. Provide URL for the dataset used. You can also add the .csv file that was used with the project to Github
  3. The text for the y-axis in a3_Visualization_Total_Grant_by_Organization.png is overlapping each other. Perhaps you can fix that.
Image

Other minor observation -
This PR includes files from Assignments 1 and 2 alongside Assignment 3 files. In real projects, it's best practice to keep separate PRs for distinct features/bugfixes. In the future, try to only include files that are relevant.
Following work flow document on slack might help to avoid this. https://uoft-dsi-certificates.slack.com/archives/D09T4F6NSBY/p1769728806500449

Copy link

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants