Skip to content

Comments

updated#1

Open
AnaKanzaTariq wants to merge 3 commits intomainfrom
assignment-1
Open

updated#1
AnaKanzaTariq wants to merge 3 commits intomainfrom
assignment-1

Conversation

@AnaKanzaTariq
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)
created anagram checker

What did you learn from the changes you have made?
making lists from string

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?
using counter function

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?
not in studied in class

How were these changes tested?
gave correct values once returned

A reference to a related issue in your repository (if applicable)
Checklist
[y] I can confirm that my changes are working as intended

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're close! For part B, there's a small error. If is_case_sensitive is True, the variables lcword_a and lcword_b won't exist! please revise.

@AnaKanzaTariq
Copy link
Owner Author

Hello, Can you tell me some other methods I could have used to do this assignment? Thank you.

Copy link

@juliagallucci juliagallucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! One note for improvement, you don’t need to explicitly return True or False since the comparison itself already evaluates to a Boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants