Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace unpkg w/ jsdelivr #2233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace unpkg w/ jsdelivr #2233

wants to merge 1 commit into from

Conversation

SukkaW
Copy link

@SukkaW SukkaW commented Mar 15, 2025

Fixes #2232 and #2230

UNPKG has not been actively maintained and has been down since Mar 15, 2025 was down from Mar 15, 2025, 2:00 AM and down for 18 hours (unpkg/unpkg#412). Migrating to jsDelivr means a more stable and reliant service.

The PR replaces UNPKG usage with jsDelivr.

See also another upstream PR: phosphor-icons/web#37

Summary by CodeRabbit

  • Chores
    • Updated the external icons script URL to use a new CDN provider for improved asset delivery without altering functionality.

Copy link

coderabbitai bot commented Mar 15, 2025

📝 Walkthrough

Walkthrough

This update modifies two HTML files to change the source URL for the Phosphor Icons script. The previous URL pointing to unpkg.com has been replaced with one from cdn.jsdelivr.net. No changes were made to functionality, logic, or public entity declarations.

Changes

File(s) Change Summary
apps/artboard/index.html
apps/client/index.html
Updated the Phosphor Icons script source URL from https://unpkg.com/* to https://cdn.jsdelivr.net/*

Poem

I'm a bunny with a hop so light,
Skipping through the code day and night.
New CDN trails in our HTML so bright,
Phosphor Icons now take flight.
Cheers from my burrow, coding feels just right!

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)
  • We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
    - To enable this feature, set early_access to true under in the settings.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cd21860 and f5136da.

📒 Files selected for processing (2)
  • apps/artboard/index.html (1 hunks)
  • apps/client/index.html (1 hunks)
🔇 Additional comments (2)
apps/client/index.html (1)

45-45: CDN URL Update for Phosphor Icons Script

The updated script tag now references jsDelivr instead of UNPKG, aligning with the PR objectives to improve reliability. This single-line change is straightforward and correctly implemented.

apps/artboard/index.html (1)

42-42: CDN URL Update for Phosphor Icons in Artboard

The script source has been updated to use jsDelivr, thereby replacing the outdated UNPKG endpoint. This change meets the objective of ensuring more stable and maintained service delivery.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@SukkaW SukkaW mentioned this pull request Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Icon
1 participant