Amber RC1 #3
Amber RC1 #3
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Slinky LSD (Liquid Staking Derivative) price sources in the Mars Oracle WASM contract. The implementation adds a new price source type that calculates LSD prices using redemption rates from Slinky LST oracle contracts combined with transitive asset pricing.
Key Changes:
- Added
SlinkyLsdprice source variant with validation and pricing logic - Created mock LST oracle contract for testing purposes
- Updated contract version from 2.2.3 to 2.3.2 with corresponding migration
Reviewed Changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| schemas/mars-oracle-wasm/mars-oracle-wasm.json | Added schema definition for new SlinkyLsd price source |
| contracts/oracle/wasm/src/price_source.rs | Implemented SlinkyLsd price source validation and querying logic |
| contracts/oracle/wasm/src/redemption_rate.rs | Added helper functions for querying Slinky LST oracle contracts |
| contracts/mock-lst-oracle/ | Created new mock contract to simulate Slinky LST oracle for testing |
| packages/testing/src/wasm_oracle.rs | Enhanced test robot with mock LST oracle support and helper methods |
| contracts/oracle/wasm/tests/tests/test_price_source.rs | Added comprehensive tests for SlinkyLsd price source validation |
| contracts/oracle/wasm/src/migrations/v2_3_2.rs | Added migration from version 2.2.3 to 2.3.2 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| /// The query message for the slinky LST oracle | ||
| /// This is the only type we need so we don't import the package | ||
| #[cw_serde] | ||
| enum QueryMsg { | ||
| GetRedemptionRate {}, | ||
| GetLstAssetDenom {}, | ||
| } |
There was a problem hiding this comment.
The comment mentions 'slinky LST oracle' but should be more specific about which oracle interface this represents. Consider adding a reference to the actual oracle contract or repository for clarity.
| ) -> ContractResult<Decimal> { | ||
| let rr = query_slinky_lst_redemption_rate(&deps.querier, contract_addr.clone())?; | ||
|
|
||
| // We don't do any staleness checks here as slinky LST contract does not provide that. |
There was a problem hiding this comment.
This comment should explain the implications of not performing staleness checks and whether this poses any risks to price accuracy or system security.
| // We don't do any staleness checks here as slinky LST contract does not provide that. | |
| // We don't do any staleness checks here as the slinky LST contract does not provide staleness information. |
No description provided.