Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2553): remove config with no properties + support metadata check for config without properties #2641

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthieu-crouzet
Copy link
Contributor

Proposed change

  • Remove config with no properties
  • Support metadata check for config without properties

Related issues

@matthieu-crouzet matthieu-crouzet requested review from a team as code owners December 20, 2024 15:01
Copy link

nx-cloud bot commented Dec 20, 2024

View your CI Pipeline Execution ↗ for commit e34b9dc.

Command Status Duration Result
nx run-many --target=test-int ❌ Failed 9m 36s View ↗
nx run-many --target=build --projects=eslint-pl... ✅ Succeeded <1s View ↗
nx run-many --target=test-e2e ✅ Succeeded 1m 51s View ↗
nx run-many --target=publish --nx-bail --userco... ✅ Succeeded 35s View ↗
nx affected --target=test --cacheDirectory=D:\a... ✅ Succeeded 34s View ↗
nx run-many --target=build ✅ Succeeded 1m 50s View ↗
nx run-many --target=documentation ✅ Succeeded 1m 19s View ↗
nx run ama-sdk-schematics:build-swagger ✅ Succeeded <1s View ↗
Additional runs (4) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2024-12-20 15:32:59 UTC

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.80%. Comparing base (c8834dc) to head (e34b9dc).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...extractor/helpers/component/component.extractor.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: check-config-migration-metadata fails on specific case
3 participants