fix: add macOS and Windows support to CI validation matrix#315
Open
mvgadagi wants to merge 13 commits into
Open
fix: add macOS and Windows support to CI validation matrix#315mvgadagi wants to merge 13 commits into
mvgadagi wants to merge 13 commits into
Conversation
mvgadagi
force-pushed
the
fix/mac-windows-arti-publish-for-prs
branch
from
b10be0b to
e898315
Compare
mvgadagi
force-pushed
the
fix/mac-windows-arti-publish-for-prs
branch
from
e898315 to
460c077
Compare
mvgadagi
force-pushed
the
fix/mac-windows-arti-publish-for-prs
branch
from
460c077 to
18336f2
Compare
…ensure proper externals configuration in webpack.config.js
… and add test for YAML quoting support
…ivation and chat participant
…f extension-activation.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The CI validation matrix in
vscode-extension-secure-ci.ymlwas only running onubuntu-latest, which meant VSIX artifacts were only built and published for Ubuntu. This PR expands the matrix to includemacos-latestandwindows-latest, ensuring VSIX packages are built and uploaded for all three major platforms.Additionally, the CI workflow's path triggers did not include
.github/workflows/**, so workflow-only changes (like this one) would not trigger CI runs. This has been fixed by adding.github/workflows/**to both thepushandpull_requestpath filters.A
.gitattributesfile has been added to enforce LF line endings on checkout, which prevents@stylistic/linebreak-styleESLint errors on Windows CI runners where git defaults to CRLF.Type of Change
Related Issues
Closes #
Changes Made
validatejob matrix in.github/workflows/vscode-extension-secure-ci.ymlfrom[ubuntu-latest]to[ubuntu-latest, macos-latest, windows-latest].github/workflows/**to thepushandpull_requestpath triggers so CI runs on workflow file changes.gitattributeswith* text=auto eol=lfto enforce LF line endings on checkout, fixing@stylistic/linebreak-styleCRLF lint errors on Windowsif: runner.os == 'Linux'conditions, so no additional changes were needed for cross-platform compatibilityshell: bashdirectives use Git Bash on Windows, which provides the required Unix tools (unzip,ls,awk)Testing
Test Coverage
Checklist
Documentation
Additional Notes
The VSIX artifacts will now be named:
vsix-ubuntu-latest-node24vsix-macos-latest-node24vsix-windows-latest-node24