Conversation
HyunJiLim0406
approved these changes
Sep 20, 2021
Member
HyunJiLim0406
left a comment
HyunJiLim0406
left a comment
There was a problem hiding this comment.
p2
수고하셨습니다! 5문제 다 잘 풀어주셨네요~
자세한 코멘트는 코드에 달아놓았으니 확인해주세요.
3613번은 좀 더 리팩토링할 수 있는 부분이 보이네요!
입력받은 문자열이 cpp인지 java인지 먼저 확인하고 java 또는 cpp로 바꾸는거 어떨까요?
함수가 4개 필요하겠네요!
이대로 머지하셔도 좋긴한데, 더 수정하고 싶으시면 수정 후 리뷰어로 저 호출해주세요!
추석 잘 보내세요 현영님!
9월 20일 - 우선순위 큐/11286.cpp
Outdated
Comment on lines
6
to
12
9월 20일 - 우선순위 큐/11723.cpp
Outdated
Comment on lines
40
to
43
Member
There was a problem hiding this comment.
이것도 아래 toggle 처럼 한 출로 나타낼 수 있어요!
9월 20일 - 우선순위 큐/11723.cpp
Outdated
Comment on lines
11
to
12
Member
There was a problem hiding this comment.
잘 푸셨습니다! 근데 이 배열조차 사용하지 않고 int 변수 하나로 문제를 풀 수 있는 방법도 있어요!
비트마스킹에 대해 알아보시겠어요? 좀 어려울 수도 있으니 알아만 보셔도 좋아요
9월 20일 - 우선순위 큐/12018.cpp
Outdated
Comment on lines
20
to
23
9월 20일 - 우선순위 큐/15903.cpp
Outdated
Comment on lines
19
to
25
Member
There was a problem hiding this comment.
여긴 중복이 조금 있으니까 반복문으로 처리해도 좋아요!
9월 20일 - 우선순위 큐/3613.cpp
Outdated
Comment on lines
55
to
56
Member
There was a problem hiding this comment.
위에 있는 if 문에 걸리면 무조건 리턴하니 이 else는 필요 없어요
9월 20일 - 우선순위 큐/3613.cpp
Outdated
Comment on lines
5
to
6
9월 20일 - 우선순위 큐/3613.cpp
Outdated
Comment on lines
38
to
41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.