Conversation
Member
HyunJiLim0406
left a comment
HyunJiLim0406
left a comment
There was a problem hiding this comment.
p3
수고하셨습니다! 1935번에 중복코드가 약간 있긴 하지만 다른 문제들은 아주 효율적으로 잘 푸셨어요~~
지금 작성하신 코드들에 함수화를 할 수 있을 부분들이 좀 보여요! 어떠한 연산결과를 리턴한다면 다 함수로 뺀다고 생각하고 리팩토링해볼까요?
시간이 없으시면 1935번에서 중복코드만 수정하셔도 돼요!
수정 후 리뷰어로 저 호출해주세요~~
9월 15일 - 스택, 큐, 덱/10866.cpp
Outdated
Comment on lines
50
to
51
Member
There was a problem hiding this comment.
와 이걸 직접구현하셨네요! 정말 잘하셨어요!!
근데 사실 삭제&삽입 연산은 front와 back에서 아주 약간 다르게 작동해요!
아무튼 정말 멋져요...!
9월 15일 - 스택, 큐, 덱/1935.cpp
Outdated
Comment on lines
18
to
22
Member
There was a problem hiding this comment.
map도 좋지만, 다른 방법도 있어요! 코드를 잘 살펴보시면 답이 나올 것 같아요~
9월 15일 - 스택, 큐, 덱/1935.cpp
Outdated
Comment on lines
32
to
59
Member
There was a problem hiding this comment.
여기 중복이 많네요! 사칙연산 함수를 만드는건 어떨까요?
9월 15일 - 스택, 큐, 덱/20920.cpp
Outdated
Comment on lines
30
to
31
9월 15일 - 스택, 큐, 덱/crane.cpp
Outdated
Comment on lines
13
to
19
9월 15일 - 스택, 큐, 덱/crane.cpp
Outdated
Comment on lines
25
to
26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.