[최단경로] 11월 26일#12
Open
ODamDam wants to merge 5 commits into
Open
Conversation
sforseohn
reviewed
Dec 3, 2024
Member
sforseohn
left a comment
sforseohn
left a comment
There was a problem hiding this comment.
[최단경로 2458, 15685번 코드 리뷰 완료]
2458, 15685(P2)
다민님 안녕하세요! 마지막 주차까지 열심히 과제하시느라 고생 많으셨습니다! 🤩🎉✨
어려운 문제인데도 잘 풀어주셨네요! 😎 정석적으로 잘 구현해주셔서 크게 코멘트 드릴 부분이 없었습니다.
궁금한 점이 있다면 리뷰어를 호출해주세요!
Comment on lines
50
to
76
Comment on lines
11
to
18
Member
There was a problem hiding this comment.
P3. 배운 개념을 활용해서 잘 구현해주셨네요 👍👍👍 조건을 한 번에 비교하면 인덴테이션이 줄어들어서 더 깔끔할 것 같기는 한데, 이건 취향의 영역인 것 같습니다...!
Comment on lines
26
to
48
Comment on lines
21
to
32
Member
There was a problem hiding this comment.
P2. 방향 벡터에 현재 방향을 순서대로 담아주고 있으므로, 좌표의 방문을 처리하는 부분을 위의 방향 계산하는 부분과 합쳐도 되겠네요🥰
Comment on lines
6
to
9
Member
There was a problem hiding this comment.
방향 배열과 최대 크기 선언해주신 부분 좋습니다 💯💯💯
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 2271086
이름: 오다민
푼 문제
필수 과제 3개(1238, 2458, 15685)