[최단경로] 1126#13
Open
minae-mina wants to merge 2 commits intomainfrom
Open
Conversation
sforseohn
reviewed
Dec 3, 2024
Member
sforseohn
left a comment
sforseohn
left a comment
There was a problem hiding this comment.
[최단경로 2458, 15685번 코드 리뷰 완료]
2458, 15685(P2)
민아님 안녕하세요! 마지막 주차까지 열심히 과제하시느라 고생 많으셨습니다! 🤩🎉✨
어려운 문제인데도 잘 풀어주셨네요! 😎 정석적으로 잘 구현해주셔서 크게 코멘트 드릴 부분이 없었습니다.
몇 가지 코멘트 드렸습니다.
궁금한 점이 있다면 리뷰어를 호출해주세요!
Comment on lines
43
to
63
Comment on lines
11
to
15
Comment on lines
47
to
48
Member
There was a problem hiding this comment.
P2. 격자의 크기를 상수 변수로 선언해서 사용하면 가독성도 좋아지고 실수할 일이 줄어들겠네요 🥰
Comment on lines
64
to
70
Member
There was a problem hiding this comment.
P2. 문제에서 드래곤 커브는 격자의 크기를 벗어나지 않는다고 했으니 x, y의 범위는 체크하지 않아도 될 것 같아요🤗🤗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 1976002
이름: 강민아
과제제출
기존 제출: 1238, 2458, 15685
추가 제출: