Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New expression functions: compare, string functions and more #2961

Merged
merged 23 commits into from
Feb 12, 2025

Conversation

olemartinorg
Copy link
Contributor

Description

This implements the following new expression functions:

  • countDataElements - counts the number of data elements in the current instance, given a type. Can for example count attachments or subform elements.
  • compare
    • Including the operators equals, greaterThan, greaterThanEq, lessThan and lessThanEq - all of which had dedicated functions already
    • isBefore, isBeforeEq, isAfter, isAfterEq and isSameDay - these are all brand new, and relies on date parsing
  • stringIndexOf, stringReplace, stringSlice, lowerCaseFirst and upperCaseFirst

Also, review comments from #2948 have also been solved here.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

Sorry, something went wrong.

@olemartinorg olemartinorg added the kind/product-feature Pull requests containing new features label Jan 31, 2025
@olemartinorg olemartinorg merged commit 414fbc8 into main Feb 12, 2025
15 checks passed
@olemartinorg olemartinorg deleted the feat/compare-and-more branch February 12, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants