Repository navigation
Close failed ClickHouse connection pools before retrying - #1578
Merged
Slach merged 3 commits intoSep 28, 2026
Merged
Conversation
Collaborator
|
thanks for contribution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ClickHouse rejects authentication or the native handshake fails,
Connectcreates a new driver pool on every retry without closing the pool whosePingfailed. Each pool keeps its drain goroutine and ticker alive, so a command that retries for a long time accumulates resources. Early returns onBreakConnectOnError, shutdown, or FIPS errors also leave the failed pool open.Close and clear the failed pool immediately after
Pingfails, before either waiting to reconnect or returning the original error.The regression test uses a local TCP server that rejects native handshakes and checks that the driver's pool drain goroutines return to their initial count. It covers immediate failure, shutdown, and a retry followed by shutdown. All three cases fail against the original code and pass with this change.
Validation:
go test ./...go test -race ./pkg/clickhouse -count=1go vet ./...