Repository navigation
fix: align Keeper TLS verification with ClickHouse settings - #1366
Merged
Merged
Conversation
Slach
approved these changes
May 7, 2026
Coverage Report for CI Build 25507910574Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage at 66.807% (no base build to compare)Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Slach
added a commit
that referenced
this pull request
May 13, 2026
PR #1366 wrote zz_keeper_tls.xml with verificationMode=strict and a CA bundle that doesn't include the test-generated ca-cert.pem used by the clickhouse-backup-fips API server, so ClickHouse failed to verify the cert when inserting into system.backup_actions (CERTIFICATE_VERIFY_FAILED on fips_test.go:112). Revert the global override to verificationMode=none / AcceptCertificateHandler (matching ssl.xml defaults), and move the strict client config into TestKeeperTLS itself where the per-test xml is already written/cleaned up. Also bump CI matrix back to clickhouse 25.8 (away from the 25.8.21 workaround), and small cleanups in serverAPI_test.go / s3_test.go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1312.
This fixes Keeper TLS verification to match ClickHouse
openSSL/clientsettings more closely.Previously the Keeper TLS code effectively collapsed verification into one
skipVerifyflag. That is not quite right:extendedVerification=falseshould skip hostname verification, but should still keep certificate chain verification enabled.This PR:
ServerNameTestKeeperTLSintegration check for the expected behaviorTested locally: