Fix format, structure and compression method detection for DataLake #746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed format detection for table function
iceberg
(fixes #732)Documentation entry for user-facing changes
With empty Iceberg table this query works:
and this not
because StorageIcebergConfiguration returns own default-initialized fields instead of fields of specific config implementation (S3, Azure or HDFS), ClickHouse tries to resolve it and it fails - for datalake format is always 'Parquet' now, but when it not filled properly, code tries to detect it from source files and fails for empty table case.
Technical changes - fields in StorageObjectStorage::Configuration now private access via getters and setters.
Logical changes - these getters and setters are overridden in StorageIcebergConfiguration to use proper implementation.