Token authentication -> edge #616
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvonand
force-pushed
the
oauth-to-edge
branch
from
fbe5c4c to
10f04f6
Compare
|
This is an automated comment for commit 2db35e6 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
zvonand
force-pushed
the
oauth-to-edge
branch
from
327789d to
ef6b54c
Compare
zvonand
force-pushed
the
oauth-to-edge
branch
from
28dbe3f to
8fbceb8
Compare
ianton-ru
reviewed
Feb 17, 2025
| @@ -152,7 +155,7 @@ bool authenticateUserByHTTP( | |||
| if (spnego_challenge.empty()) | |||
| throw Exception(ErrorCodes::AUTHENTICATION_FAILED, "Invalid authentication: SPNEGO challenge is empty"); | |||
| } | |||
| else | |||
| else if (Poco::icompare(scheme, "Bearer") < 0) | |||
ianton-ru
reviewed
Feb 17, 2025
|
|
||
| #### Parameters: | ||
|
|
||
| - `provider` - name of provider that will be used for token processing. Mandatory parameter. Possible options: `google`. |
ianton-ru
reviewed
Feb 17, 2025
| In order to enable JWT authentication for the user, specify `jwt` section instead of `password` or other similar sections in the user definition. | ||
|
|
||
| Parameters: | ||
| - `claims` - An optional string containing a json object that should be contained in the token payload. |
There was a problem hiding this comment.
If take me as reference customer and document reader, it's not clean, what exactly can be in payload.
I found docs for Google (https://developers.google.com/wallet/reference/rest/v1/Jwt) and MS (https://learn.microsoft.com/en-us/entra/identity-platform/access-token-claims-reference) and saw there other fields, but no resource_access.
May be add some links here, or samples for different providers?
There was a problem hiding this comment.
Actually, I inherited this thing, and I think I will remove it: it can be confusing indeed, and its use case is not obvious. Also, it makes code somewhat more complex
ianton-ru
reviewed
Feb 17, 2025
| <users> | ||
| <!- ... --> | ||
| <my_user> | ||
| <!- ... --> |
zvonand
force-pushed
the
oauth-to-edge
branch
from
44be855 to
ec9421d
Compare
zvonand
force-pushed
the
oauth-to-edge
branch
2 times, most recently
from
7e1dfac to
2db35e6
Compare
zvonand
force-pushed
the
oauth-to-edge
branch
3 times, most recently
from
722d7e3 to
82a3904
Compare
Add aspell Enable jwt-cpp in fasttest Add test + some minor improvements reduce unneeded possible clash points fix parsing create user identified with jwt refactor + fix not lowercase update test fix typo in docs fix logical_error some refactor fix alg in jwks fix jwks fix user auth method not being checked update docs better exception on no sub claim throw exception if algo not specified in jwk Support access token authorization of existing users Also possible to filter users by e-mail using regex fix token accessstorage Add Azure token processor, move JWKS logic to separate file remove docs that will be obsolete in future remove redundant
fix credentials cast + some better code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce token (OAuth) authentication.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Introduce token (OAuth) authentication.
Documentation entry for user-facing changes