fix: [AI-1759] target selector affects query execution and shows current target#1849
Open
ralphstodomingo wants to merge 1 commit intomasterfrom
Open
fix: [AI-1759] target selector affects query execution and shows current target#1849ralphstodomingo wants to merge 1 commit intomasterfrom
ralphstodomingo wants to merge 1 commit intomasterfrom
Conversation
…current target - Pass `selectedTarget` to the target picker so the current target is shown first with a "(current)" label - Sort picker items to place the active target at the top Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
WalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedTargetto the target picker command so the current target is shown first with a "(current)" labelContext
Fixes #1759
The target selector QuickPick always showed the first target (usually
dev) as highlighted, regardless of which target was actually active. This made it unclear which target was currently selected.Companion PR: AltimateAI/altimate-dbt-integration#37 (passes
target_nameto Python bridge for query execution)Test plan
🤖 Generated with Claude Code