Skip to content

Fix favor_state not used when merging manifest #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anandgupta42 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix favor_state not used when merging manifest #1660

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ae7b9
fix defer favor-state not applied
anandgupta42 May 17, 2025
4bf1106
Merge branch 'master' into auto-coding-agent/fix-db-sync-to-query-pro…
anandgupta42 May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dbt_core_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ def safe_parse_project(self) -> None:
manifest = Manifest.from_writable_manifest(writable_manifest)
self.dbt.merge_from_artifact(
other=manifest,
favor_state=self.favor_state,
Copy link
Copy Markdown
Contributor

@mdesmet mdesmet May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signature of this function from dbt is:

 # Called in GraphRunnableTask.before_run, RunTask.before_run, CloneTask.before_run
    def merge_from_artifact(self, other: "Manifest") -> None:

)
else:
with open(self.defer_to_prod_manifest_path) as f:
Expand Down
Loading