Skip to content

fix: show save for editing tests in doc panel #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
saravmajestic wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: show save for editing tests in doc panel #1618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions webview_panels/src/modules/documentationEditor/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,11 @@ import { panelLogger } from "@modules/logger";
import {
DBTDocumentation,
DBTDocumentationColumn,
DbtGenericTests,
DocumentationStateProps,
Source,
TestMetadataAcceptedValuesKwArgs,
TestMetadataRelationshipsKwArgs,
} from "./state/types";
import { GenerationDBDataProps } from "./types";
import { DataPilotChatAction } from "../dataPilot/types";
Expand Down Expand Up @@ -166,6 +169,30 @@ export const isStateDirty = (state: DocumentationStateProps): boolean => {
if (!incomingTest) {
return true;
}
if (test.test_metadata?.name === DbtGenericTests.ACCEPTED_VALUES) {
if (
(
test.test_metadata?.kwargs as TestMetadataAcceptedValuesKwArgs
).values?.join(",") !==
(
incomingTest.test_metadata?.kwargs as TestMetadataAcceptedValuesKwArgs
).values?.join(",")
) {
return true;
}
}
if (test.test_metadata?.name === DbtGenericTests.RELATIONSHIPS) {
const currentTestsArgs = test.test_metadata
?.kwargs as TestMetadataRelationshipsKwArgs;
const incomingTestsArgs = incomingTest.test_metadata
?.kwargs as TestMetadataRelationshipsKwArgs;
if (
currentTestsArgs.to !== incomingTestsArgs.to ||
currentTestsArgs.field !== incomingTestsArgs.field
) {
return true;
}
}
}
return false;
};
Expand Down
Loading