fix: restore does not exist to validation error keywords#614
fix: restore does not exist to validation error keywords#614anandgupta42 merged 1 commit intomainfrom
does not exist to validation error keywords#614Conversation
The keyword was removed in #611 to prevent HTTP 404 messages from being misclassified as validation errors. However, the pattern reordering (http_error now comes before validation) already handles that — HTTP 404 messages match `http_error` first via `"http 404"` keyword. Removing `"does not exist"` from validation caused SQL errors like `"column foo does not exist"` to fall through to `unknown`. Restore the keyword and add a test for the SQL case. Caught by multi-model code review (Claude + Gemini 3.1 Pro consensus). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 9 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Restores
"does not exist"to thevalidationerror classification keywords. It was removed in #611 to prevent HTTP 404 misclassification, but the pattern reordering in the same PR already handles that —http_errornow has priority overvalidation. The removal caused SQL errors like"column foo does not exist"to fall through tounknown.Type of change
Issue for this PR
Closes #613
How did you verify your code works?
telemetry.test.ts,time.test.ts,edit.test.ts,write.test.ts)"error: column foo does not exist"→validation"HTTP 404: ... does not exist"→http_error(still works via pattern priority)--markers --base main --strict)Checklist
🤖 Generated with Claude Code