Skip to content

fix: restore does not exist to validation error keywords#614

Merged
anandgupta42 merged 1 commit intomainfrom
fix/filetime-telemetry-followup
Apr 2, 2026
Merged

fix: restore does not exist to validation error keywords#614
anandgupta42 merged 1 commit intomainfrom
fix/filetime-telemetry-followup

Conversation

@anandgupta42
Copy link
Copy Markdown
Contributor

What does this PR do?

Restores "does not exist" to the validation error classification keywords. It was removed in #611 to prevent HTTP 404 misclassification, but the pattern reordering in the same PR already handles that — http_error now has priority over validation. The removal caused SQL errors like "column foo does not exist" to fall through to unknown.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Issue for this PR

Closes #613

How did you verify your code works?

  • 195/195 tests pass (telemetry.test.ts, time.test.ts, edit.test.ts, write.test.ts)
  • New test case: "error: column foo does not exist"validation
  • Existing test: "HTTP 404: ... does not exist"http_error (still works via pattern priority)
  • Upstream marker check passes (--markers --base main --strict)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

🤖 Generated with Claude Code

The keyword was removed in #611 to prevent HTTP 404 messages from being
misclassified as validation errors. However, the pattern reordering
(http_error now comes before validation) already handles that — HTTP 404
messages match `http_error` first via `"http 404"` keyword. Removing
`"does not exist"` from validation caused SQL errors like
`"column foo does not exist"` to fall through to `unknown`.

Restore the keyword and add a test for the SQL case.

Caught by multi-model code review (Claude + Gemini 3.1 Pro consensus).

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Warning

Rate limit exceeded

@anandgupta42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 9 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 4 minutes and 9 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9ec70462-2579-4e4e-b72f-0daf0073b529

📥 Commits

Reviewing files that changed from the base of the PR and between 086d7b2 and 3c71187.

📒 Files selected for processing (2)
  • packages/opencode/src/altimate/telemetry/index.ts
  • packages/opencode/test/telemetry/telemetry.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/filetime-telemetry-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@anandgupta42 anandgupta42 merged commit a68ce29 into main Apr 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: restore does not exist to validation error classification

1 participant