Skip to content

fix: Config.update() writes to wrong file, PATCH /config settings silently lost #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saravmajestic wants to merge 4 commits into
base: main
Choose a base branch
from
+6 −3
Open

fix: Config.update() writes to wrong file, PATCH /config settings silently lost #505

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
de3bd94
fix: `Config.update()` writes to wrong file, settings via `PATCH /con…
saravmajestic Mar 27, 2026
794b110
test: update config test to expect opencode.json instead of config.json
saravmajestic Mar 27, 2026
bc852ac
fix: remove stale @ts-expect-error in sqlserver.ts — @types/mssql now…
saravmajestic Mar 27, 2026
cb95365
Merge branch 'main' into fix/config-update-wrong-filename
anandgupta42 Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/opencode/src/config/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1425,7 +1425,11 @@ export namespace Config {
}

export async function update(config: Info) {
const filepath = path.join(Instance.directory, "config.json")
// Find an existing project config file, or default to opencode.json.
// ConfigPaths.projectFiles("opencode", ...) looks for opencode.jsonc and opencode.json,
// so we must write to one of those — not config.json which is never loaded by state().
const projectFiles = await ConfigPaths.projectFiles("opencode", Instance.directory, Instance.worktree)
const filepath = projectFiles[projectFiles.length - 1] ?? path.join(Instance.directory, "opencode.json")
const existing = await loadFile(filepath)
await Filesystem.writeJson(filepath, mergeDeep(existing, config))
await Instance.dispose()
Expand Down
Loading