-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lauri/enhancement/363 redesign scrolltop component #389
Open
LauriHiltunen
wants to merge
11
commits into
dev
Choose a base branch
from
lauri/enhancement/363-redesign-scrolltop-component
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lauri/enhancement/363 redesign scrolltop component #389
LauriHiltunen
wants to merge
11
commits into
dev
from
lauri/enhancement/363-redesign-scrolltop-component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/Alt-Org/Altzone-WebPages into lauri/enhancement/363-redesign-scrolltop-component
Skoivumaki
requested changes
Feb 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please center align the "arrows" inside the mobile scrolltop button. Currently its slightly off center.
Feedback based off screenshots, have not tested actual code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
closes #363
🔧 Changes Made
app[lng](helper)\admin\page.tsx
features\ScrollTop\index.ts
features\ScrollTop\ui\v2\ScrollTop.tsx
features\ScrollTop\ui\v2\ScrollTop.module.scss
features\ScrollTop\ui\v2\ScrollTop.test.tsx
features\ScrollTop\ui\v2\ScrollTop.stories.tsx
Added a new version of the
ScrollTop component
and added it to the /en/admin page.Deprecated the
old ScrollTop component
.✅ Checklist Before Submission
📝 Additional Information
Admin page: http://localhost:5173/en/admin
Storybook: http://localhost:6006/?path=/story/features-scrolltopv2--default
The new
Scrolltop component
on different devices: