Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lauri/enhancement/363 redesign scrolltop component #389

Open
wants to merge 11 commits into
base: dev
Choose a base branch
from

Conversation

LauriHiltunen
Copy link

@LauriHiltunen LauriHiltunen commented Feb 10, 2025

📄 Pull Request Overview

closes #363

🔧 Changes Made

app[lng](helper)\admin\page.tsx

features\ScrollTop\index.ts
features\ScrollTop\ui\v2\ScrollTop.tsx
features\ScrollTop\ui\v2\ScrollTop.module.scss
features\ScrollTop\ui\v2\ScrollTop.test.tsx
features\ScrollTop\ui\v2\ScrollTop.stories.tsx

Added a new version of the ScrollTop component and added it to the /en/admin page.

Deprecated the old ScrollTop component.


Checklist Before Submission

  • Functionality: I have tested my code, and it works as expected.

📝 Additional Information

Admin page: http://localhost:5173/en/admin
Storybook: http://localhost:6006/?path=/story/features-scrolltopv2--default

The new Scrolltop component on different devices:

ScrollTopV2

Copy link
Member

@Skoivumaki Skoivumaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please center align the "arrows" inside the mobile scrolltop button. Currently its slightly off center.
Feedback based off screenshots, have not tested actual code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants