Kaisa/refactor/377 refactor development page to use new sidebar #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents the arrow icons to not hide under longer words
Update it to render the correct NavMenuWithDropdowns based on screen size. Also set min-width to 250px so dropdown is wide enough in smaller screens in collapsed state.
kaisahakola
requested review from
leolabdev,
MikhailDeriabin,
Jonroi and
Skoivumaki
as code owners
Jonroi
requested changes
Feb 7, 2025
Primary color when closed and secondary color when opened. Also add some styling: cursor pointer for the titles and a hover color change.
Remove underline from non active subdropdowns and remove arrow icons from subdropdowns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
closes #377
🔧 Changes Made
Updated the hero development page to use the new DropdownWrapperV2 sidebar.
Set the sidebars min-width a bit wider so longer words fit better when screen size reduces.
✅ Checklist Before Submission
console.log()or other debugging statements are left.