Jarno/feature/84-add-sitemap #370
Open
+333
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k in this version for some reason
Rutjake
requested review from
leolabdev,
MikhailDeriabin,
Jonroi,
Skoivumaki and
kaisahakola
as code owners
leolabdev
requested changes
Jan 30, 2025
| export default function sitemap(): MetadataRoute.Sitemap { | ||
| return [ | ||
| { | ||
| url: 'https://altzone.fi', |
There was a problem hiding this comment.
Please use envHelper instead harcoding
There was a problem hiding this comment.
Do you mean just the domain or also the subpages?
…rent parts of the application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Pull Request Overview
closes #84
🔧 Changes Made
Created sitemap.ts, which should automatically create sitemap.xml. The current next.js version does not support localization, but I made a function without it. This feature can be easily added after updating Next. I also added a general sitemap.xml file as well as fi/sitemap.xml and en/sitemap.xml, so that sitemaps work in both languages when searched (localization). I created the files manually because the current Next project has either a version or configuration issue with the automatic sitemap.xml creation, which I couldn't figure out. I modified robots.txt so that search engine crawlers can find the sitemaps. Added the component to Storybook, where it worked as expected.
✅ Checklist Before Submission
I have tested my code, and it works as expected in Storybook.
I have added or updated JSDoc comments for all relevant code.
📝 Additional Information
The current Next version does not support localization in the sitemap component.
Prioritization and page update information may need updating. After creating new pages, it is a good idea to update the component and the xml files.