Skip to content

Preview deploy failures post no comment on the pull request #1134

Description

@bennyvasquez

When the Cloudflare Pages step in .github/workflows/publish-preview.yml fails, the Comment deployment URL on PR step (line 103) is skipped, so nothing is posted to the pull request.

The step has a fallback message for this case, but it is unreachable: a step with no if: condition only runs when every earlier step succeeded.

: `⚠️ Preview deployment step finished with status: ${status}.`;

Seen on #1132, where a transient Cloudflare API error (code: 8000000) failed the job. Re-running it unchanged succeeded.

Fix: add if: always() && steps.pr.outputs.number to the comment step. The second condition matters because Resolve and verify PR number can fail, leaving nothing to comment on.

Drafted with AI assistance.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions