Skip to content

Wip/export stage coords #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 4, 2025
Merged

Wip/export stage coords #128

merged 13 commits into from
Mar 4, 2025

Conversation

hannalee2
Copy link
Collaborator

image

Export global stage coords is done.

logger.debug(f"Serial number {sn} not found in transformation or scale dictionary")

# Update stage info into JSON
self._write_stage_info_to_json(moving_stage)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for writing this info when starting the listener?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for implementation to communicate with Ephys-link in the future. Kenneth and I have a meeting today(12pm-4pm) in person for the implementation in details.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can remove this function for now and added again in other PR (implementation to talk with Ephys-link)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #128

file_path = os.path.join(data_dir, f"{stage.sn}.json") # Store the file in the correct location

# Create the stage data dictionary
stage_data = self._get_stage_info_json(stage)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should check with Kanghoon about this, but it might be better to write the position of all stages to the same file when the button is clicked, not just the selected one.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that makes sense. I will ask scientists which format would be better.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed #128
Example)
image
filename: YYYY-MM-DDTHHMMSS±HHMM.json

@hannalee2 hannalee2 merged commit ee660c0 into main Mar 4, 2025
2 checks passed
@hannalee2 hannalee2 deleted the wip/export_stage_coords branch April 3, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants