#817 Don't confuse tables where one name is a prefix of the other#820
Open
pgarrison wants to merge 4 commits into
Open
#817 Don't confuse tables where one name is a prefix of the other#820pgarrison wants to merge 4 commits into
pgarrison wants to merge 4 commits into
Conversation
BrianWhitneyAI
approved these changes
Jun 1, 2026
SeanDuHare
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Resolves #817
Changes
To work around the underlying bug, register files to duck DB with an appended
-bff-filehandle. Unfortunately, this means updating every place where the SQL references the file handle name to use the newfileHandleNamefunction. It's a little tricky to ensure all of these sites were identified: I missed the ones inparquetHasBlankValuesat first. I suspect all of the sites that need to change are in the data source preparation phase, because subsequent queries use view/table names instead.Testing
Three manual tests:
tiny.parquetandtiny2.parquetand verify both appear as distinct data sources with correct row counts.parquet_metadata: Load a single parquet file with a column containing blank/whitespace values and confirm the column filter UI correctly identifies blanks.