Add test cases: aggregate 10M+10M, 20M#806
Conversation
f923aa3 to
15eeadf
Compare
BrianWhitneyAI
left a comment
There was a problem hiding this comment.
I am worried that this aggregate benchmark is too much to put on top of the existing benchmark and should be split out into separate scripts.
| "resize-observer": "1.0.x", | ||
| "rimraf": "3.0.x", | ||
| "sinon": "12.x", | ||
| "tsx": "^4.21.0", |
There was a problem hiding this comment.
whats the change around the locks?
There was a problem hiding this comment.
I am just slightly worried about dep changes for code that isnt directly used by the app. This was more a comment about those changes as a whole rather than specifically "tsx"
There was a problem hiding this comment.
ah seeing its in the dev dependecies in the comment below makes me less worried about this
| "resize-observer": "1.0.x", | ||
| "rimraf": "3.0.x", | ||
| "sinon": "12.x", | ||
| "tsx": "^4.21.0", |
There was a problem hiding this comment.
The versions are handled via the "x" version classifier as opposed to ~ or ^.
Bummer this has to be included in the web deploy
| "tsx": "^4.21.0", | |
| "tsx": "4.21.x", |
There was a problem hiding this comment.
It's in the dev dependencies, so it shouldn't be in the deployment? Perhaps I'm misunderstanding.
(Updated the version syntax in 6079147)
Co-authored-by: Sean Du'Hare <41307451+SeanDuHare@users.noreply.github.com>
|
Latest benchmark run: https://github.com/AllenInstitute/biofile-finder/actions/runs/26601221187 |
BrianWhitneyAI
left a comment
There was a problem hiding this comment.
Thank you for fixing my bad error commit!
|
Latest benchmark run: https://github.com/AllenInstitute/biofile-finder/actions/runs/26655081926 |
Purpose
Test query performance of large aggregate parquets.
Changes
npm run benchmark:*scripts instead of direct node calls.Testing
npm run benchmarkandnpm run benchmark:summarywith--warmups=0Reviewing
Note: the base branch is a temporary development branch, the result of merging PRs #739 and #787, both dependencies of this branch.