Feature/provenance updates#804
Merged
Merged
Conversation
…feature/provenance-updates
…feature/provenance-updates
This was
linked to
issues
May 19, 2026
…feature/provenance-updates
BrianWhitneyAI
approved these changes
May 20, 2026
SeanDuHare
approved these changes
May 28, 2026
Contributor
SeanDuHare
left a comment
There was a problem hiding this comment.
Minor thoughts - LGTM regardless
SeanDuHare
reviewed
May 28, 2026
| @@ -47,8 +46,28 @@ const NODE_TYPES = { | |||
| * Component for rendering a graph at the given origin | |||
Contributor
There was a problem hiding this comment.
This is awesome! What do you think about one step further so that no user of the component has to really think about it? This way they would import an already wrapped graph, but that part is shoved away nicely (IMO)
function NetworkGraph(props: NetworkGraphProps) {
...body of function as is...
}
export default function WrappedNetworkGraph(props: NetworkGraphProps) {
return (
<ReactFlowProvider>
<NetworkGraph {...props} />
</ReactFlowProvider>
);
}
Contributor
Author
There was a problem hiding this comment.
That makes sense to me! Implemented in dddd5cb, I was split on whether or not to rename the import in RelationshipDiagram but left it as is for now, open to changing it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
These are the visual interaction updates to the provenance graph.
Resolves #650, #651, #652, #654, #655
To do:
Resize Observererror appears in deployed versions of the graphChanges
ReactFlowlibrary to surfacefitView, so needed to wrap theReactFlowcomponent inside of aReactFlowProvider(provides access to the internal state)FileDetailsPanelmatch how it appears in the main app. Undoes the graph view-specific customizations we'd previously addedTesting
Screenshots (if relevant)
Before: Graph
After: Graph
Before vs After: File details panel