Skip to content

Feature/provenance updates#804

Merged
aswallace merged 15 commits into
mainfrom
feature/provenance-updates
May 28, 2026
Merged

Feature/provenance updates#804
aswallace merged 15 commits into
mainfrom
feature/provenance-updates

Conversation

@aswallace
Copy link
Copy Markdown
Contributor

@aswallace aswallace commented May 19, 2026

Context

These are the visual interaction updates to the provenance graph.
Resolves #650, #651, #652, #654, #655

To do:

  • Display provenance button in file details panel and have it redraw the graph when clicked
  • Check whether Resize Observer error appears in deployed versions of the graph
  • Replace all remaining references to "provenance" in UI to "relationship diagram"
  • Make url change so that can use browser back buttons

Changes

Testing

Screenshots (if relevant)

Before: Graph

Screenshot 2026-05-18 at 4 50 10 PM

After: Graph

Screenshot 2026-05-18 at 4 50 24 PM

Before vs After: File details panel

Screenshot 2026-05-18 at 4 56 11 PM Screenshot 2026-05-18 at 4 56 22 PM

Comment thread packages/core/components/FileDetails/index.tsx
Comment thread packages/core/styles/global.css
@aswallace aswallace linked an issue May 20, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@SeanDuHare SeanDuHare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thoughts - LGTM regardless

Comment thread packages/core/components/NetworkGraph/index.tsx Outdated
Comment thread packages/core/components/NetworkGraph/index.tsx Outdated
@@ -47,8 +46,28 @@ const NODE_TYPES = {
* Component for rendering a graph at the given origin
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! What do you think about one step further so that no user of the component has to really think about it? This way they would import an already wrapped graph, but that part is shoved away nicely (IMO)

function NetworkGraph(props: NetworkGraphProps) {
    ...body of function as is...
}

export default function WrappedNetworkGraph(props: NetworkGraphProps) {
    return (
            <ReactFlowProvider>
                <NetworkGraph {...props} />
            </ReactFlowProvider>
     );
 }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me! Implemented in dddd5cb, I was split on whether or not to rename the import in RelationshipDiagram but left it as is for now, open to changing it

@aswallace aswallace merged commit 9412ed3 into main May 28, 2026
7 checks passed
@aswallace aswallace linked an issue May 28, 2026 that may be closed by this pull request
@aswallace aswallace deleted the feature/provenance-updates branch May 28, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants