Enable multi-download: group batch downloads into a single status notification#769
Draft
Copilot wants to merge 10 commits into
Draft
Enable multi-download: group batch downloads into a single status notification#769Copilot wants to merge 10 commits into
Copilot wants to merge 10 commits into
Conversation
Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/19d8fc8b-c988-4eaa-a37a-00f8ff4bf75e Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
…ith Show more toggle Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/19d8fc8b-c988-4eaa-a37a-00f8ff4bf75e Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add multi-download functionality with grouped messages
Enable multi-download: group batch downloads into a single status notification
May 1, 2026
SeanDuHare
reviewed
May 1, 2026
SeanDuHare
requested changes
May 1, 2026
…ped download notifications Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/32fbf7b9-d2fc-43cb-b23a-25058fee49e9 Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
The download stuff is just SOOOOOOOOO messy - I'm trying to clean it up which is something the AI agents are... not helpful at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Downloading multiple files at once produced a separate notification banner per file, cluttering the UI. This change groups all downloads triggered together into one consolidated status message with a collapsible file list.
Changes
state/interaction/actions.tsfullMsg?: stringtoStatusUpdate.data— carries the full untruncated message for "View more" expansion (replaces the earlierfileNamesarray approach)processStart,processProgress, andprocessErrorsignatures with optionalfullMsgparameterstate/interaction/logics.ts(core change)downloadRequestIdprocess messages with a singlegroupProcessIdfor the entire batchcancelFileDownloadfor each individual requestmsg(header + first 3 file names as HTML) andfullMsg(header + all file names), only settingfullMsgwhen there are more than 3 filescomponents/StatusMessage/index.tsxexpandedIdsstate +toggleExpandedto track per-process expansionmsgby default; switches tofullMsgwhen expanded:displayMsg = isExpanded && fullMsg ? fullMsg : msgfullMsgis presentTesting
logics.test.ts: "downloads multiple files" now asserts exactly oneSET_STATUSaction is dispatched for the batch, containing allfileIdentries