Add Ctrl+A / Cmd+A keybind to select all files in current file set#758
Add Ctrl+A / Cmd+A keybind to select all files in current file set#758Copilot wants to merge 23 commits into
Conversation
Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/74f1643e-52fc-4cad-8e3f-ecc2aa5cd830 Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
… still open Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/15cc38b3-57aa-4745-9b9f-c85c0367fd85 Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
…ertions Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/15cc38b3-57aa-4745-9b9f-c85c0367fd85 Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/e490a34b-f925-49fb-bdd3-eeb34cd0b0dd Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
…lder mismatch Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/e490a34b-f925-49fb-bdd3-eeb34cd0b0dd Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
…ve unnecessary INITIALIZE_APP reset Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/a7d3238e-9ae3-4216-b28f-45a5b2b628f3 Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
…eSelectAll Agent-Logs-Url: https://github.com/AllenInstitute/biofile-finder/sessions/a7d3238e-9ae3-4216-b28f-45a5b2b628f3 Co-authored-by: SeanDuHare <41307451+SeanDuHare@users.noreply.github.com>
SeanDuHare
left a comment
SeanDuHare
left a comment
There was a problem hiding this comment.
Reviewed UX with Lyndsay - removed tracking last opened folders per her suggestion
| ]).slice(0, 5), | ||
|
|
||
| // Reset file selections when file filters change | ||
| // Reset file selections and last touched folder when file filters change |
There was a problem hiding this comment.
lastTouchedFolder is reset when file filters change, but it's not actually included
in the returned state only fileSelection is cleared. This means after a user applies or removes a file filter,
Ctrl+A can still target a stale folder from before the filter was changed.
There was a problem hiding this comment.
Good point! This is a stray comment addition from pre my change to remove tracking the last opened folder. I reverted this comment line to reflect the reality of the implementation
There was a problem hiding this comment.
I think we still need to update SET_FILE_FILTERS to clear lastTouchedFolder
There was a problem hiding this comment.
We want the last touched folder to remain the same even when the filters change since it is technically still the same folder - in the case of the hierarchy changing we do want it to change. The file selection getting cleared lets us avoid any issues where select all wouldve selected too many or too few files
|
I've been testing this locally and for some reason getting a bunch of |
(EDIT) I can't reproduce this :( |
…r issues with aggregation
Context
Users have wanted the ability to "select all" within a file set
Description
This PR adds "select all" functionality via keybind cmd+a/ctrl+a that lets users select all files within a file set. To do so they must first select or deselect a file within the file set or be at the root (as in no groups)
Testing
Tested locally across different group and filtering combos