Skip to content

Fixed bow, crossbow, trident, armors and maces stacking up to 64. Fix… #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RenanOSX wants to merge 2 commits into
base: 1.21.x
Choose a base branch
from
Open

Fixed bow, crossbow, trident, armors and maces stacking up to 64. Fix… #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ca748
Fixed bow, crossbow, trident, armors and maces stacking up to 64. Fix…
RenanOSX Nov 7, 2025
6720cb4
Update README.md
RenanOSX Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Fixes
Fixed gear items stacking up to 64
14 changes: 7 additions & 7 deletions src/main/java/com/thevortex/allthemodium/registry/ArmorRegistries.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,24 @@ public class ArmorRegistries {
@SuppressWarnings("unchecked")
public static final Map<ArmorItem.Type,Integer> ALLTHEMODIUM = (EnumMap)Util.make(new EnumMap(ArmorItem.Type.class), (allthemodium) -> {
allthemodium.put(ArmorItem.Type.HELMET, 4);
allthemodium.put(ArmorItem.Type.CHESTPLATE, 7);
allthemodium.put(ArmorItem.Type.LEGGINGS, 9);
allthemodium.put(ArmorItem.Type.CHESTPLATE, 9);
allthemodium.put(ArmorItem.Type.LEGGINGS, 7);
allthemodium.put(ArmorItem.Type.BOOTS, 4);
allthemodium.put(ArmorItem.Type.BODY, 8);});

@SuppressWarnings("unchecked")
public static final Map<ArmorItem.Type,Integer> VIBRANIUM = (EnumMap)Util.make(new EnumMap(ArmorItem.Type.class), (vibranium) -> {
vibranium.put(ArmorItem.Type.HELMET, 6);
vibranium.put(ArmorItem.Type.CHESTPLATE, 9);
vibranium.put(ArmorItem.Type.LEGGINGS, 11);
vibranium.put(ArmorItem.Type.CHESTPLATE, 11);
vibranium.put(ArmorItem.Type.LEGGINGS, 9);
vibranium.put(ArmorItem.Type.BOOTS, 6);
vibranium.put(ArmorItem.Type.BODY, 10);});

@SuppressWarnings("unchecked")
public static final Map<ArmorItem.Type,Integer> UNOBTAINIUM = (EnumMap)Util.make(new EnumMap(ArmorItem.Type.class), (unobtainium) -> {
unobtainium.put(ArmorItem.Type.HELMET, 8);
unobtainium.put(ArmorItem.Type.CHESTPLATE, 11);
unobtainium.put(ArmorItem.Type.LEGGINGS, 13);
unobtainium.put(ArmorItem.Type.CHESTPLATE, 13);
unobtainium.put(ArmorItem.Type.LEGGINGS, 11);
unobtainium.put(ArmorItem.Type.BOOTS, 8);
unobtainium.put(ArmorItem.Type.BODY, 12);});

Expand All @@ -51,4 +51,4 @@ public class ArmorRegistries {
public static final DeferredHolder<ArmorMaterial,ArmorMaterial> UNOB = ARMOR_MATERIALS.register("unobtainium", () -> new ArmorMaterial(UNOBTAINIUM, 125, SoundEvents.ARMOR_EQUIP_NETHERITE, () -> Ingredient.of(ModRegistry.UNOBTAINIUM_INGOT.get()), List.of(new ArmorMaterial.Layer(ResourceLocation.fromNamespaceAndPath(Reference.MOD_ID,"unobtainium"))), 15.0F, 1.0f));


}
}
41 changes: 18 additions & 23 deletions src/main/java/com/thevortex/allthemodium/registry/ModRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,28 +103,24 @@ public class ModRegistry {

// ARMORS

public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_HELMET = ITEMS.register("allthemodium_helmet", () -> new Allthemodium_Helmet(ArmorRegistries.ATM, EquipmentSlot.HEAD, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_CHESTPLATE = ITEMS.register("allthemodium_chestplate", () -> new Allthemodium_Chestplate(ArmorRegistries.ATM, EquipmentSlot.CHEST, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_LEGGINGS = ITEMS.register("allthemodium_leggings", () -> new Allthemodium_Leggings(ArmorRegistries.ATM, EquipmentSlot.LEGS, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_BOOTS = ITEMS.register("allthemodium_boots", () -> new Allthemodium_Boots(ArmorRegistries.ATM, EquipmentSlot.FEET, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_HELMET = ITEMS.register("allthemodium_helmet", () -> new Allthemodium_Helmet(ArmorRegistries.ATM, EquipmentSlot.HEAD, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_CHESTPLATE = ITEMS.register("allthemodium_chestplate", () -> new Allthemodium_Chestplate(ArmorRegistries.ATM, EquipmentSlot.CHEST, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_LEGGINGS = ITEMS.register("allthemodium_leggings", () -> new Allthemodium_Leggings(ArmorRegistries.ATM, EquipmentSlot.LEGS, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> ALLTHEMODIUM_BOOTS = ITEMS.register("allthemodium_boots", () -> new Allthemodium_Boots(ArmorRegistries.ATM, EquipmentSlot.FEET, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));


public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_HELMET = ITEMS.register("vibranium_helmet", () -> new Allthemodium_Helmet(ArmorRegistries.VIB, EquipmentSlot.HEAD, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_CHESTPLATE = ITEMS.register("vibranium_chestplate", () -> new Allthemodium_Chestplate(ArmorRegistries.VIB, EquipmentSlot.CHEST, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_LEGGINGS = ITEMS.register("vibranium_leggings", () -> new Allthemodium_Leggings(ArmorRegistries.VIB, EquipmentSlot.LEGS, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_BOOTS = ITEMS.register("vibranium_boots", () -> new Allthemodium_Boots(ArmorRegistries.VIB, EquipmentSlot.FEET, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_HELMET = ITEMS.register("vibranium_helmet", () -> new Allthemodium_Helmet(ArmorRegistries.VIB, EquipmentSlot.HEAD, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_CHESTPLATE = ITEMS.register("vibranium_chestplate", () -> new Allthemodium_Chestplate(ArmorRegistries.VIB, EquipmentSlot.CHEST, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_LEGGINGS = ITEMS.register("vibranium_leggings", () -> new Allthemodium_Leggings(ArmorRegistries.VIB, EquipmentSlot.LEGS, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> VIBRANIUM_BOOTS = ITEMS.register("vibranium_boots", () -> new Allthemodium_Boots(ArmorRegistries.VIB, EquipmentSlot.FEET, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));

public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_HELMET = ITEMS.register("unobtainium_helmet", () -> new Allthemodium_Helmet(ArmorRegistries.UNOB, EquipmentSlot.HEAD, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_CHESTPLATE = ITEMS.register("unobtainium_chestplate", () -> new Allthemodium_Chestplate(ArmorRegistries.UNOB, EquipmentSlot.CHEST, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_LEGGINGS = ITEMS.register("unobtainium_leggings", () -> new Allthemodium_Leggings(ArmorRegistries.UNOB, EquipmentSlot.LEGS, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_BOOTS = ITEMS.register("unobtainium_boots", () -> new Allthemodium_Boots(ArmorRegistries.UNOB, EquipmentSlot.FEET, new Item.Properties().fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_HELMET = ITEMS.register("unobtainium_helmet", () -> new Allthemodium_Helmet(ArmorRegistries.UNOB, EquipmentSlot.HEAD, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_CHESTPLATE = ITEMS.register("unobtainium_chestplate", () -> new Allthemodium_Chestplate(ArmorRegistries.UNOB, EquipmentSlot.CHEST, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_LEGGINGS = ITEMS.register("unobtainium_leggings", () -> new Allthemodium_Leggings(ArmorRegistries.UNOB, EquipmentSlot.LEGS, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));
public static final DeferredHolder<Item,ArmorItem> UNOBTAINIUM_BOOTS = ITEMS.register("unobtainium_boots", () -> new Allthemodium_Boots(ArmorRegistries.UNOB, EquipmentSlot.FEET, new Item.Properties().fireResistant().rarity(Rarity.EPIC).stacksTo(1)));



//Volcano



public static final DeferredHolder<Block, AncientCaveVines> ANCIENT_CAVEVINES_ = PILLARBLOCKS.register("ancient_cavevines", () -> new AncientCaveVines(BlockBehaviour.Properties.of()
.randomTicks()
.noCollission()
Expand Down Expand Up @@ -480,7 +476,6 @@ private static RotatedPillarBlock log(DyeColor color1, DyeColor color2) {
return new RotatedPillarBlock(BlockBehaviour.Properties.of().strength(2.0F).sound(SoundType.WOOD));
}


public static final DeferredHolder<Item,SwordItem> ATM_SWORD = ITEMS.register("allthemodium_sword", () -> new SwordItem(ATMTier.ALLTHEMODIUM, (new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).attributes(SwordItem.createAttributes(ATMTier.ALLTHEMODIUM, 5, -1.4F))));
public static final DeferredHolder<Item,SwordItem> VIB_SWORD = ITEMS.register("vibranium_sword", () -> new SwordItem(ATMTier.VIBRANIUM, (new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).attributes(SwordItem.createAttributes(ATMTier.VIBRANIUM, 10, -0.4F))));
public static final DeferredHolder<Item,SwordItem> UNO_SWORD = ITEMS.register("unobtainium_sword", () -> new SwordItem(ATMTier.UNOBTAINIUM, (new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).attributes(SwordItem.createAttributes(ATMTier.UNOBTAINIUM, 15, 0.4F))));
Comment on lines 479 to 481
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The swords (lines 479-481) and pickaxes (lines 483-485) are missing .stacksTo(1) in their properties. While tools with durability typically default to stack size 1, these items are marked as unbreakable, and explicit .stacksTo(1) should be added for consistency with the maces, bow, crossbow, and trident that are being fixed in this PR. The same issue applies to axes (487-489), shovels (491-493), hoes (495-497), and the alloy tools (513-517), though those are outside the changed region.

Copilot uses AI. Check for mistakes.
Expand All @@ -502,17 +497,17 @@ private static RotatedPillarBlock log(DyeColor color1, DyeColor color2) {
public static final DeferredHolder<Item,HoeItem> UNO_HOE = ITEMS.register("unobtainium_hoe", () -> new HoeItem(ATMTier.UNOBTAINIUM, (new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).attributes(HoeItem.createAttributes(ATMTier.UNOBTAINIUM, -1, 0.0F))));


public static final DeferredHolder<Item,MaceItem> ATM_MACE = ITEMS.register("allthemodium_mace", () -> new ATMMace(ATMTier.ALLTHEMODIUM,(new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMMace.createToolProperties(ATMTier.ALLTHEMODIUM)).attributes(ATMMace.createAttributes(ATMTier.ALLTHEMODIUM))));
public static final DeferredHolder<Item,MaceItem> VIB_MACE = ITEMS.register("vibranium_mace", () -> new ATMMace(ATMTier.VIBRANIUM,(new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMMace.createToolProperties(ATMTier.VIBRANIUM)).attributes(ATMMace.createAttributes(ATMTier.VIBRANIUM))));
public static final DeferredHolder<Item,MaceItem> UNO_MACE = ITEMS.register("unobtainium_mace", () -> new ATMMace(ATMTier.UNOBTAINIUM,(new Item.Properties()).rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMMace.createToolProperties(ATMTier.UNOBTAINIUM)).attributes(ATMMace.createAttributes(ATMTier.UNOBTAINIUM))));
public static final DeferredHolder<Item,MaceItem> ATM_MACE = ITEMS.register("allthemodium_mace", () -> new ATMMace(ATMTier.ALLTHEMODIUM,(new Item.Properties()).rarity(Rarity.EPIC).stacksTo(1).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMMace.createToolProperties(ATMTier.ALLTHEMODIUM)).attributes(ATMMace.createAttributes(ATMTier.ALLTHEMODIUM))));
public static final DeferredHolder<Item,MaceItem> VIB_MACE = ITEMS.register("vibranium_mace", () -> new ATMMace(ATMTier.VIBRANIUM,(new Item.Properties()).rarity(Rarity.EPIC).stacksTo(1).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMMace.createToolProperties(ATMTier.VIBRANIUM)).attributes(ATMMace.createAttributes(ATMTier.VIBRANIUM))));
public static final DeferredHolder<Item,MaceItem> UNO_MACE = ITEMS.register("unobtainium_mace", () -> new ATMMace(ATMTier.UNOBTAINIUM,(new Item.Properties()).rarity(Rarity.EPIC).stacksTo(1).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMMace.createToolProperties(ATMTier.UNOBTAINIUM)).attributes(ATMMace.createAttributes(ATMTier.UNOBTAINIUM))));

public static final DeferredHolder<Item,BowItem> ATM_BOW = ITEMS.register("allthemodium_bow", () -> new ATMBow((new Item.Properties()).fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,BowItem> ATM_BOW = ITEMS.register("allthemodium_bow", () -> new ATMBow((new Item.Properties()).fireResistant().rarity(Rarity.EPIC).stacksTo(1)));

public static final DeferredHolder<Item,CrossbowItem> UNO_BOW = ITEMS.register("unobtainium_crossbow", () -> new Unobow((new Item.Properties()).fireResistant().rarity(Rarity.EPIC)));
public static final DeferredHolder<Item,CrossbowItem> UNO_BOW = ITEMS.register("unobtainium_crossbow", () -> new Unobow((new Item.Properties()).fireResistant().rarity(Rarity.EPIC).stacksTo(1)));

public static final DeferredHolder<Item,ShieldItem> VIB_SHIELD = ITEMS.register("vibranium_shield", () -> new Vib_Shield((new Item.Properties()).fireResistant().stacksTo(1).rarity(Rarity.EPIC)));

public static final DeferredHolder<Item,TridentItem> ALLOY_TRIDENT = ITEMS.register("alloy_trident", () -> new ATMTrident((new Item.Properties()).fireResistant().rarity(Rarity.EPIC).attributes(ATMTrident.createAttributes()).component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMTrident.createToolProperties())));
public static final DeferredHolder<Item,TridentItem> ALLOY_TRIDENT = ITEMS.register("alloy_trident", () -> new ATMTrident((new Item.Properties()).fireResistant().rarity(Rarity.EPIC).stacksTo(1).attributes(ATMTrident.createAttributes()).component(DataComponents.UNBREAKABLE, new Unbreakable(true)).component(DataComponents.TOOL, ATMTrident.createToolProperties())));
public static final DeferredHolder<EntityType<?>,EntityType<ThrownATMTrident>> ALLOY_TRIDENT_ENTITY = ENTITIES.register("alloy_trident", () -> EntityType.Builder.<ThrownATMTrident>of(ThrownATMTrident::new, MobCategory.MISC).sized(0.5F, 0.5F).clientTrackingRange(4).updateInterval(10).build("alloy_trident"));

public static final DeferredHolder<Item,SwordItem> ALLOY_SWORD = ITEMS.register("alloy_sword", () -> new SwordItem(ATMTier.ALLOY, new Item.Properties().rarity(Rarity.EPIC).fireResistant().component(DataComponents.UNBREAKABLE, new Unbreakable(true)).attributes(SwordItem.createAttributes(ATMTier.ALLOY, 3, 2.9F))));
Expand Down