Add vanilla Shield & Twilight Forest armors / weapons to the Salvager#1917
Open
SteveHeist wants to merge 2 commits intoAllTheMods:mainfrom
Open
Add vanilla Shield & Twilight Forest armors / weapons to the Salvager#1917SteveHeist wants to merge 2 commits intoAllTheMods:mainfrom
SteveHeist wants to merge 2 commits intoAllTheMods:mainfrom
Conversation
Contributor
Author
|
...dang, this has been ignored |
Contributor
|
This needs to be reviewed by someone who knows if there is any impact/loophole with balance if the game. |
Contributor
|
If you can explain the impacts for those who will review you are welcome |
pietro-lopes
requested review from
Mitchell5200,
Nyxane,
Satherov,
TheBedrockMaster and
djnifos
Member
|
I feel like the Shield recipe is something that doesn't exist already for a reason, otherwise I guess it should be suggested to the mod itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my continued quest to never have to leave anything in loot chests, I've added the vanilla Shield - dropped by a lot of the Dungeon mobs - and some of the Twilight Forest armor and weapons that have crafting recipes to the Salvager.