Skip to content
This repository was archived by the owner on Dec 2, 2024. It is now read-only.

Conversation

@openhands-agent
Copy link
Collaborator

This pull request fixes #329.

The issue has been successfully resolved. The AI agent correctly identified and addressed the core dependency conflict by:

  1. Moving pytest to test dependencies (where it belongs) instead of main dependencies
  2. Setting explicit version constraints that satisfy all requirements:
    • pytest >=8.3.3,<9.0.0 (satisfies openhands-resolver's requirement)
    • pytest-mock >=3.14.0 (which is compatible with the pytest version)

The solution was verified through practical tests:

  • Dependencies were successfully locked with poetry
  • Installation completed without conflicts
  • Tests passed after the changes

For a GitHub review, this would be summarized as:
"This PR resolves the dependency conflict by properly scoping pytest as a test dependency and setting version constraints that satisfy all package requirements. The changes have been verified through successful installation and test execution. The solution maintains compatibility with openhands-resolver while ensuring proper dependency management practices."

Automatic fix generated by OpenHands 🙌

@neubig
Copy link
Contributor

neubig commented Nov 12, 2024

@openhands-agent the pandas version requirement is still very stringent. could this be loosened as well?

@github-actions
Copy link

OpenHands started fixing the issue! You can monitor the progress here.

@neubig neubig added the fix-me Try to automatically fix the issue with OpenHands label Nov 12, 2024
@github-actions
Copy link

OpenHands started fixing the pr! You can monitor the progress here.

@github-actions
Copy link

The workflow to fix this issue encountered an error. Openhands failed to create any code changes.

@neubig neubig marked this pull request as ready for review November 12, 2024 22:43
@neubig neubig enabled auto-merge (squash) November 12, 2024 22:43
malhotra5 and others added 5 commits November 13, 2024 01:34
* adding macro invocation to PRs

* adding macro invocation for PRs

* raising error when no comment with macro is found

* fix value error statement

* adding test cases for fetch issues with comment id for PRs

* reducing duplication on workflow
* grabbing bodies for referenced issues in comment bodies

* considering thread comments for issue refs

* updating tests

* adding tests for external issue refs

1. checking correct issues refs are included when comment_id is present

2. checking that duplicates issues refs are not included multiple times
@neubig neubig disabled auto-merge November 13, 2024 01:39
@neubig
Copy link
Contributor

neubig commented Nov 13, 2024

Let's close this and re-open.

@neubig neubig closed this Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

fix-me Try to automatically fix the issue with OpenHands

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug] pip dependency conflict error: pytest version conflict with openhands-resolver

4 participants