Skip to content

fix(vdd): probe direct capture without DDX - #881

Draft
qiin2333 wants to merge 1 commit into
masterfrom
codex/fix-vdd-probe-ddx
Draft

fix(vdd): probe direct capture without DDX#881
qiin2333 wants to merge 1 commit into
masterfrom
codex/fix-vdd-probe-ddx

Conversation

@qiin2333

@qiin2333 qiin2333 commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

改了啥呀

  • 显式配置 capture = vdd 时,编码器探测直接使用 VDD,不再偷偷覆盖成 DDX
  • 解析并锁定 ZakoVDD 对应的输出,只对这个确认过的虚拟输出跳过 Desktop Duplication 可用性检查
  • VDD 枚举时排除其他物理/幽灵输出,避免自动选择跑偏
  • 删除已经不再需要的 per-display capture backend override

为啥要改

Hyper-V GPU-PV 来宾可以使用 NVENC,但 DXGI Desktop Duplication 可能完全不可用。旧逻辑却在真正尝试 VDD 前强制用 DDX 探测编码器,结果这个 DDX 门卫把 VDD 自己拦在门外了,真是杂鱼 bug 呀。

这个修复只影响用户显式选择 VDD 的路径;普通 DDX/WGC 和自动捕获逻辑保持不变,VDD 初始化失败后的 DDX fallback 也仍然保留。

Fixes #880

验证

  • Windows Release:src/video.cpp 对象编译通过
  • Windows Release:src/platform/windows/display_base.cpp 对象编译通过
  • 本地现有 VDD 安全测试:18/18 通过
  • PR CI:Build Windows、native tests、Package Windows 全部通过
  • git diff --check 通过

测试包

  • CI artifact:sunshine-windows-r2143
  • 解压后安装 Sunshine..WindowsInstaller.exe
  • 产物保留到 2026-10-29

希望 #880 的报告者在 Hyper-V GPU-PV + ZakoVDD 环境验证启动探测和实际串流,嘿嘿,这次不让 DDX 把 VDD 挡在门外啦。

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: fe9d7913-2158-4c93-8241-c8315b05fc9e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Yundi339

Copy link
Copy Markdown
Member

如果主机的显卡就是不支持ZakoHDR,这个改动可能反而把兜底机制搞没了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: # Encoder probe forces ddx and ignores capture = vdd, making Zako Direct Capture unusable on systems where DDX cannot work (Hyper-V GPU-PV)

2 participants