fix(vdd): probe direct capture without DDX - #881
Draft
qiin2333 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Member
|
如果主机的显卡就是不支持ZakoHDR,这个改动可能反而把兜底机制搞没了 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
改了啥呀
capture = vdd时,编码器探测直接使用 VDD,不再偷偷覆盖成 DDX为啥要改
Hyper-V GPU-PV 来宾可以使用 NVENC,但 DXGI Desktop Duplication 可能完全不可用。旧逻辑却在真正尝试 VDD 前强制用 DDX 探测编码器,结果这个 DDX 门卫把 VDD 自己拦在门外了,真是杂鱼 bug 呀。
这个修复只影响用户显式选择 VDD 的路径;普通 DDX/WGC 和自动捕获逻辑保持不变,VDD 初始化失败后的 DDX fallback 也仍然保留。
Fixes #880
验证
src/video.cpp对象编译通过src/platform/windows/display_base.cpp对象编译通过git diff --check通过测试包
Sunshine..WindowsInstaller.exe希望 #880 的报告者在 Hyper-V GPU-PV + ZakoVDD 环境验证启动探测和实际串流,嘿嘿,这次不让 DDX 把 VDD 挡在门外啦。