WIP- Adding MSIG endpoint to get familiar with the API IOC code pattern.#75
Draft
dallasjohnson wants to merge 2 commits intomasterfrom
Draft
WIP- Adding MSIG endpoint to get familiar with the API IOC code pattern.#75dallasjohnson wants to merge 2 commits intomasterfrom
dallasjohnson wants to merge 2 commits intomasterfrom
Conversation
rkamysz
reviewed
Aug 22, 2023
| * The `MSIGAggregateRecord` class is responsible for creating an aggregated record that contains information about a MSIGProposal | ||
| * and its related data. | ||
| */ | ||
| export class MSIGAggregateRecord { |
There was a problem hiding this comment.
I would consider it as an entity not a model. this is not bad but the model should be simple and we are thinking to get rid of the models in the domain (in that form).
| * | ||
| * @class | ||
| */ | ||
| export class Proposal implements Entity { |
There was a problem hiding this comment.
Filename is plural and should be singular like class name
| @inject(GetAllMSIGSUseCase.Token) | ||
| private getAllMSIGSUseCase: GetAllMSIGSUseCase, | ||
| @inject(CreateAggregatedMSIGRecords.Token) | ||
| private createAggregatedMSIGRecords: CreateAggregatedMSIGRecords |
| * @class | ||
| */ | ||
| @injectable() | ||
| export class CreateAggregatedMSIGRecords |
| @@ -0,0 +1,31 @@ | |||
| import { Transaction } from '../use-cases/get-decoded-msig-txn.use-case'; | |||
dallasjohnson
force-pushed
the
adding-msig-endpoint
branch
from
dca7c38 to
b35e1d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress to create an endpoint for the MSIGs.
I wanted to try to get through the process to know if the community would be able to contribute to the code.
This endpoint works but I'm sure I've broken the pattern in some places.