Skip to content

fix(core-contract): register_resolver has no caller authentication — critical auth bypass #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Userhorlie wants to merge 4 commits into from
Closed

fix(core-contract): register_resolver has no caller authentication — critical auth bypass #244

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9eda5b
fix(core-contract): register_resolver has no caller authentication — …
Userhorlie Mar 27, 2026
b45ae69
fix(core-contract): register_resolver has no caller authentication — …
Userhorlie Mar 27, 2026
6e545cd
fix: Update lib.rs
Userhorlie Mar 27, 2026
c8db627
Merge branch 'main' into fix/core-register-resolver-auth
Userhorlie Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions gateway-contract/contracts/core_contract/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,31 +61,32 @@ impl Contract {
proof: Bytes,
public_signals: PublicSignals,
) {
// ✅ CRITICAL FIX: enforce authentication FIRST
caller.require_auth();

let key = storage::DataKey::Resolver(commitment.clone());

if env.storage().persistent().has(&key) {
panic_with_error!(&env, CoreError::DuplicateCommitment);
}

let current_root = smt_root::SmtRoot::get_root(env.clone())
.unwrap_or_else(|| panic_with_error!(&env, CoreError::RootNotSet));

if public_signals.old_root != current_root {
panic_with_error!(&env, CoreError::StaleRoot);
}

if !zk_verifier::ZkVerifier::verify_groth16_proof(&env, &proof, &public_signals) {
panic_with_error!(&env, CoreError::InvalidProof);
}

let data = ResolveData {
wallet: caller.clone(),
memo: None,
};

env.storage().persistent().set(&key, &data);

smt_root::SmtRoot::update_root(&env, public_signals.new_root);

#[allow(deprecated)]
env.events()
.publish((REGISTER_EVENT,), (commitment, caller));
Expand Down
Loading