-
Notifications
You must be signed in to change notification settings - Fork 274
AAE-33907 Adds input for 'Open next task' checkbox #10823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Adds an input to the task screen component to determine whether the "Open next task" checkbox is checked by default. Also, adds an output that emits an event when the state of the "Open next task" checkbox changes.
3fc04ab
to
a71ba23
Compare
this.loadTask(); | ||
this.taskCompleted.emit(this.taskId); | ||
this.taskCompleted.emit(openNextTask); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be verified by someone, we couldn't find any usage of the TaskId provided by this emitter. We need a confirmation about that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use it at IDP but I cannot guarantee that no one else does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed the taskId because it was used in any place. but we are not 100% sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't found any place where this is used
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
There is no checkbox for "Open next task"
What is the new behaviour?
There is a checkbox for "Open next task" which will automatically opens the next task if checked.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: