Skip to content

AAE-33907 Adds input for 'Open next task' checkbox #10823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

mcoune
Copy link

@mcoune mcoune commented Apr 25, 2025

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
There is no checkbox for "Open next task"

What is the new behaviour?
There is a checkbox for "Open next task" which will automatically opens the next task if checked.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

mcoune added 4 commits May 8, 2025 15:04
Adds an input to the task screen component to determine whether the "Open next task" checkbox is checked by default.

Also, adds an output that emits an event when the state of the "Open next task" checkbox changes.
@APuschkin APuschkin force-pushed the feature/AAE-33907_Open-next-task-in-screens branch from 3fc04ab to a71ba23 Compare May 8, 2025 13:04
this.loadTask();
this.taskCompleted.emit(this.taskId);
this.taskCompleted.emit(openNextTask);
Copy link
Author

@mcoune mcoune May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be verified by someone, we couldn't find any usage of the TaskId provided by this emitter. We need a confirmation about that.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use it at IDP but I cannot guarantee that no one else does.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed the taskId because it was used in any place. but we are not 100% sure.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't found any place where this is used

@mcoune mcoune removed the PR: draft label May 16, 2025
@mcoune mcoune marked this pull request as ready for review May 16, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants