Ng19 migration latest #10795
Open
Ng19 migration latest #10795
+11,394
−18,409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
MichalKinas
approved these changes
Apr 16, 2025
AleksanderSklorz
approved these changes
Apr 16, 2025
|
VitoAlbano
reviewed
May 15, 2025
| @@ -31,7 +31,6 @@ import { TranslateModule } from '@ngx-translate/core'; | |||
|
|
|||
| @Component({ | |||
| selector: 'adf-content-metadata-card', | |||
| standalone: true, | |||
There was a problem hiding this comment.
Just as extra info: Careful here, we decided to move fully on standalone and reverting this will create issues along the way for sure @DenysVuika
There was a problem hiding this comment.
@VitoAlbano thanks, in angular 19 standalone: true is default, so I removed those adnotations :)
dominikiwanekhyland
force-pushed
the
ng19-migration-latest
branch
from
442f120 to
7f7af9e
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: