[AAE-32905] - Improving ADF PR workflow #10720
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitoAlbano
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
VitoAlbano
added
do not merge 🙅🏻♂️
do not review
😢 Drama approaching
ehsan-2019
approved these changes
Mar 13, 2025
VitoAlbano
changed the title
VitoAlbano
force-pushed
the
improvement/AAE-32905-rework-PR-pipeline
branch
from
2c0a21d to
43887ff
Compare
|
in my opinion it would be better to have the generate step for the specific target instead of 1 global build unit |
ehsan-2019
reviewed
Apr 1, 2025
ehsan-2019
reviewed
Apr 1, 2025
ehsan-2019
reviewed
Apr 1, 2025
VitoAlbano
force-pushed
the
improvement/AAE-32905-rework-PR-pipeline
branch
from
75cea0b to
8537138
Compare
| @@ -0,0 +1,52 @@ | |||
| name: "Build Lib Workflow" | |||
There was a problem hiding this comment.
follow the naming convention
_build_libs.yaml
| name: "Build Lib Workflow" | ||
|
|
||
| on: | ||
| workflow_call: {} |
There was a problem hiding this comment.
why do u need it? if there are no inputs
| AFFECTED_UNIT=$(npx nx show projects --affected --target=test --base=origin/$BASE_REF --select=projects --plain --exclude=cli,stories,eslint-angular) | ||
| echo "Affected projects for BUILD : $AFFECTED_BUILD" | ||
| BUILD_MATRIX_JSON=$(echo $AFFECTED_BUILD | xargs -n1 | jq -R -s -c 'split("\n")[:-1] | map({ "project": . })') | ||
| BUILD_MATRIX_JSON=$(echo "$BUILD_MATRIX_JSON" | tr -d '\n' | sed 's/"$//') |
There was a problem hiding this comment.
why don t get json from the show instead of plain?
| - name: Generate affected projects matrix | ||
| id: set-matrix | ||
| run: | | ||
| BASE_REF="${{ github.event.pull_request.base.ref }}" |
There was a problem hiding this comment.
\i would prefer to have JS script or node action ( preferred)
VitoAlbano
force-pushed
the
improvement/AAE-32905-rework-PR-pipeline
branch
from
c32eec8 to
e5295e5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: