OPSEXP-3057 Refactor repository role to use default vars #1091
+103
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
reviewed
Mar 3, 2025
gionn
reviewed
Mar 3, 2025
alxgomz
reviewed
Mar 4, 2025
There was a problem hiding this comment.
What about we set a fact for acs_play_repository_acs_edition == "Enterprise" e.g. acs_isEnterprise?
| @@ -4,8 +4,6 @@ if [ $(id -u) -eq 0 ]; then | |||
| exit | |||
| fi | |||
| . {{ config_folder }}/setenv.sh | |||
| {% if acs.version is version('7.2.0', '>=') -%} | |||
There was a problem hiding this comment.
Why are we getting rid of this condition and not the same one in repo role?
| @@ -71,3 +71,8 @@ argument_specs: | |||
| required: false | |||
| description: | | |||
| The URL to download the checksum of the transformers All-In-One artifact. | |||
| transformers_repository_acs_edition: | |||
| type: str | |||
There was a problem hiding this comment.
Maybe add choices with accepted values. https://docs.ansible.com/ansible/latest/playbook_guide/playbooks_reuse_roles.html#specification-format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: OPSEXP-3057