Merged
Conversation
allyhawkins
approved these changes
Jan 28, 2026
Member
allyhawkins
left a comment
allyhawkins
left a comment
There was a problem hiding this comment.
Just two typos but otherwise LGTM
Co-authored-by: Ally Hawkins <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482
This PR updates docs following inferCNV changes. The only change needed was for the status variable.
For the description, I listed out the 4* (not 3 as stated in issue) strings we expect may happen with portal data: success, failure, insufficient_reference_cells, skipped_non_cancerous. I then state that other values are possible and the QC report will describe the situation.
Let me know what you think!