#2275 Backlight: Add minimum brightness #3637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As currently it is possible to turn the brightness to zero which may not be desirable, this patch add a configurable brightness check.
TripleTrable
force-pushed
the
backlight/add_min_brightness
branch
from
e910b5d to
47f767b
Compare
|
Default should still be zero to avoid breaking change |
In such case @TripleTrable you should assign 0.0 |
|
I'll work on it once im back from Work |
|
Done. Any other requested changed? |
|
LGTM thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently it is possible to turn the brightness to zero which may not be desirable, this patch add a configurable brightness check.