Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Happy Linter #2625

Merged
merged 1 commit into from
Nov 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/modules/cava.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace cava {
extern "C" {
#include <cava/common.h>
}
}
} // namespace cava

namespace waybar::modules {
using namespace std::literals::chrono_literals;
Expand Down
2 changes: 1 addition & 1 deletion src/modules/custom.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ void waybar::modules::Custom::parseOutputRaw() {
int i = 0;
while (getline(output, line)) {
Glib::ustring validated_line = line;
if(!validated_line.validate()) {
if (!validated_line.validate()) {
validated_line = validated_line.make_valid();
}

Expand Down
4 changes: 2 additions & 2 deletions src/modules/hyprland/workspaces.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ auto Workspaces::register_ipc() -> void {
}

auto Workspaces::update() -> void {
//remove workspaces that wait to be removed
// remove workspaces that wait to be removed
unsigned int current_remove_workspace_num = 0;
for (const std::string &workspace_to_remove : workspaces_to_remove_) {
remove_workspace(workspace_to_remove);
Expand All @@ -163,7 +163,7 @@ auto Workspaces::update() -> void {
workspaces_to_remove_.erase(workspaces_to_remove_.begin());
}

//add workspaces that wait to be created
// add workspaces that wait to be created
unsigned int current_create_workspace_num = 0;
for (Json::Value const &workspace_to_create : workspaces_to_create_) {
create_workspace(workspace_to_create);
Expand Down
10 changes: 6 additions & 4 deletions src/modules/mpris/mpris.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -575,10 +575,12 @@ auto Mpris::getPlayerInfo() -> std::optional<PlayerInfo> {

errorexit:
std::string errorMsg = error->message;
// When mpris checks for active player sessions periodically(5 secs), NoActivePlayer error message is
// thrown when there are no active sessions. This error message is spamming logs without having any value
// addition. Log the error only if the error we recceived is not NoActivePlayer.
if(errorMsg.rfind("GDBus.Error:com.github.altdesktop.playerctld.NoActivePlayer") == std::string::npos){
// When mpris checks for active player sessions periodically(5 secs), NoActivePlayer error
// message is
// thrown when there are no active sessions. This error message is spamming logs without having
// any value addition. Log the error only if the error we recceived is not NoActivePlayer.
if (errorMsg.rfind("GDBus.Error:com.github.altdesktop.playerctld.NoActivePlayer") ==
std::string::npos) {
spdlog::error("mpris[{}]: {}", info.name, error->message);
}
return std::nullopt;
Expand Down